input: force feedback updates, second time
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest13 patches 11 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/13 | input: move fixp-arith.h to drivers/inputdrivers/ drivers/ drivers/ | +93 | 0 replies | |
| 2/13 | input: fix accuracy of fixp-arith.hdrivers/ | +3 | 0 replies | |
| 3/13 | input: make input a multi-object moduledrivers/ drivers/ drivers/ | +1101 | 13 replies | |
| 4/13 | input: new force feedback interfacedrivers/ drivers/ drivers/ +4 more | +1019 | 0 replies | |
| 5/13 | input: adapt hid force feedback drivers for the new interfacedrivers/ drivers/ drivers/ +2 more | +81 | 0 replies | |
| 6/13 | input: adapt uinput for the new force feedback interfacedrivers/ include/ | +77 | 0 replies | |
| 7/13 | input: adapt iforce driver for the new force feedback interfacedrivers/ drivers/ drivers/ | +86 | 0 replies | |
| 8/13 | input: force feedback driver for PID devicesdrivers/ drivers/ drivers/ +3 more | +1416 | 0 replies | |
| 9/13 | input: force feedback driver for Zeroplus devicesdrivers/ drivers/ drivers/ +2 more | +139 | 0 replies | |
| 10/13 | input: update documentation of force feedbackDocumentation/ include/ | +54 | 0 replies | |
| 11/13 | input: drop the remains of the old ff interfaceinclude/ | +0 | 0 replies | |
| 12/13 | input: drop the old PID driverdrivers/ drivers/ | +0 | 0 replies | |
| 13/13 | input: use -ENOSPC instead of -ENOMEM in iforce when device fulldrivers/ | +4 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [patch 00/13] input: force feedback updates, second time
Major update for the force feedback support, including a new force feedback driver interface and two new HID ff drivers.
This is the same patchset that I sent 10 days ago, now with the following changes:
- ugly cond_locking dropped
- 80-column rule now followed
- some function opening braces newlined and unneeded braces removed
- DECLARE_BITMAP used in input_ff_timer()
- effects are fd specific instead of the previous behaviour [1]
- uses setup_timer()
- no new module added, but code is instead compiled into input module (input.c is renamed to input-core.c)
- EXPORT_SYMBOL_GPL() used
- no -ENOSYS return values
- non-atomic bit operations used in most places of input-ff.c
- some comments are added
- new patch for -ENOMEM => -ENOSPC in iforce-ff.c
- UINPUT_VERSION define added in uinput.h
- drop obsolete static function declaration from hid-lgff.c
- pr_debug() used
[1] There are no known ff programs that depend on the old behaviour. Daniel Remenak, who has been coding linux ff support for several programs, agrees to the change. The old behaviour is not documented anywhere, so most likely nobody even knew about it (Daniel didn't).
I described this in another mail already, but here it is again:
old behaviour:
- fd1 opened
- fd1: effects 0, 1 are created
- fd2 opened
- fd2: effects 2, 3 are created
- fd2 closed
=> effects 0, 1, 2, 3 get deleted
- fd1 uses effects
=> failure
- fd1 closed
new behaviour:
- fd1 opened
- fd1: effects 0, 1 are created
- fd2 opened
- fd2: effects 2, 3 are created
- fd2 closed
=> effects 2, 3 get deleted
- fd1 uses effects
- fd1 closed
=> effects 0, 1 get deleted
(fd1 and fd2 are of the same process and the same device)
Signature · 1 line
Anssi Hannula