Skip to content

input: force feedback updates, second time

Anssi Hannula lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest13 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/13input: move fixp-arith.h to drivers/inputdrivers/input/fixp-arith.h drivers/usb/input/fixp-arith.h drivers/usb/input/hid-lgff.c+93 -930 replies
2/13input: fix accuracy of fixp-arith.hdrivers/input/fixp-arith.h+3 -30 replies
3/13input: make input a multi-object moduledrivers/input/Makefile drivers/input/input-core.c drivers/input/input.c+1101 -109913 replies
4/13input: new force feedback interfacedrivers/input/Kconfig drivers/input/Makefile drivers/input/evdev.c +4 more+1019 -180 replies
5/13input: adapt hid force feedback drivers for the new interfacedrivers/usb/input/Kconfig drivers/usb/input/hid-input.c drivers/usb/input/hid-lgff.c +2 more+81 -7440 replies
6/13input: adapt uinput for the new force feedback interfacedrivers/input/misc/uinput.c include/linux/uinput.h+77 -200 replies
7/13input: adapt iforce driver for the new force feedback interfacedrivers/input/joystick/iforce/iforce-ff.c drivers/input/joystick/iforce/iforce-main.c drivers/input/joystick/iforce/iforce.h+86 -1780 replies
8/13input: force feedback driver for PID devicesdrivers/usb/input/Kconfig drivers/usb/input/Makefile drivers/usb/input/hid-ff.c +3 more+1416 -310 replies
9/13input: force feedback driver for Zeroplus devicesdrivers/usb/input/Kconfig drivers/usb/input/Makefile drivers/usb/input/hid-ff.c +2 more+139 -00 replies
10/13input: update documentation of force feedbackDocumentation/input/ff.txt include/linux/input.h+54 -540 replies
11/13input: drop the remains of the old ff interfaceinclude/linux/input.h+0 -70 replies
12/13input: drop the old PID driverdrivers/usb/input/pid.c drivers/usb/input/pid.h+0 -3570 replies
13/13input: use -ENOSPC instead of -ENOMEM in iforce when device fulldrivers/input/joystick/iforce/iforce-ff.c+4 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 00/13] input: force feedback updates, second time

Major update for the force feedback support, including a new force feedback driver interface and two new HID ff drivers.

This is the same patchset that I sent 10 days ago, now with the following changes:

- ugly cond_locking dropped
- 80-column rule now followed
- some function opening braces newlined and unneeded braces removed
- DECLARE_BITMAP used in input_ff_timer()
- effects are fd specific instead of the previous behaviour [1]
- uses setup_timer()
- no new module added, but code is instead compiled into input module (input.c is renamed to input-core.c)
- EXPORT_SYMBOL_GPL() used
- no -ENOSYS return values
- non-atomic bit operations used in most places of input-ff.c
- some comments are added
- new patch for -ENOMEM => -ENOSPC in iforce-ff.c
- UINPUT_VERSION define added in uinput.h
- drop obsolete static function declaration from hid-lgff.c
- pr_debug() used

[1] There are no known ff programs that depend on the old behaviour. Daniel Remenak, who has been coding linux ff support for several programs, agrees to the change. The old behaviour is not documented anywhere, so most likely nobody even knew about it (Daniel didn't).

I described this in another mail already, but here it is again:

old behaviour:
- fd1 opened
- fd1: effects 0, 1 are created
- fd2 opened
- fd2: effects 2, 3 are created
- fd2 closed
=> effects 0, 1, 2, 3 get deleted
- fd1 uses effects
=> failure
- fd1 closed

new behaviour:
- fd1 opened
- fd1: effects 0, 1 are created
- fd2 opened
- fd2: effects 2, 3 are created
- fd2 closed
=> effects 2, 3 get deleted
- fd1 uses effects
- fd1 closed
=> effects 0, 1 get deleted

(fd1 and fd2 are of the same process and the same device)

Signature · 1 line
Anssi Hannula