Skip to content

RFC vfs: per-superblock unused dentries list (2nd version)

[email protected] linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 27 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5vfs: remove whitespace noise from fs/dcache.cfs/dcache.c+64 -640 replies
2/5vfs: d_genocide() doesnt add dentries to unused listfs/dcache.c+16 -20 replies
3/5vfs: remove shrink_dcache_anon()fs/dcache.c fs/super.c include/linux/dcache.h+51 -530 replies
4/5vfs: per superblock dentry statsfs/dcache.c fs/super.c include/linux/dcache.h +2 more+46 -260 replies
5/5vfs: per superblock dentry unused listfs/dcache.c fs/super.c include/linux/fs.h+75 -860 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/5] [PATCH,RFC] vfs: per-superblock unused dentries list (2nd version)

This patch series is an updated version of my original patches.

This is an attempt to have per-superblock unused dentry lists. Since dentries are lazy-removed from the unused list, one big list doesn't scale very good wrt systems with a hugh dentry cache. The dcache shrinkers spend a long time traversing the list under the dcache spinlock.

The patches introduce an additional list_head per superblock holding only the dentries of the specific superblock. The next dentry can be found quickly so the shrinkers don't need to hold the dcache lock for long.

One nice side-effect: the "busy inodes after unmount" race is fixed because prune_dcache() is getting the s_umount lock before it starts working on the superblock's dentries.

Comments?
Jan