Skip to content

RFC snd-aoa: add snd-aoa

Johannes Berg alsa-devel linuxppc-dev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest12 patches 34 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12snd-powermac: no longer handle anything with a layout-id propertysound/ppc/Makefile sound/ppc/pmac.c sound/ppc/pmac.h +2 more+10 -42417 replies
2/12snd-aoa: add aoa header filessound/aoa/aoa-gpio.h sound/aoa/aoa.h+212 -00 replies
3/12snd-aoa: add aoa coresound/aoa/core/Makefile sound/aoa/core/snd-aoa-alsa.c sound/aoa/core/snd-aoa-alsa.h +3 more+913 -04 replies
4/12snd-aoa: add soundbussound/aoa/soundbus/Kconfig sound/aoa/soundbus/Makefile sound/aoa/soundbus/core.c +2 more+512 -00 replies
5/12snd-aoa: add i2sbussound/aoa/soundbus/i2sbus/Makefile sound/aoa/soundbus/i2sbus/i2sbus-control.c sound/aoa/soundbus/i2sbus/i2sbus-control.h +4 more+1934 -05 replies
6/12snd-aoa: add onyx codecsound/aoa/codecs/snd-aoa-codec-onyx.c sound/aoa/codecs/snd-aoa-codec-onyx.h+1189 -00 replies
7/12snd-aoa: add tas codecsound/aoa/codecs/snd-aoa-codec-tas-gain-table.h sound/aoa/codecs/snd-aoa-codec-tas.c sound/aoa/codecs/snd-aoa-codec-tas.h+909 -01 reply
8/12snd-aoa: add toonie codecsound/aoa/codecs/snd-aoa-codec-toonie.c+140 -00 replies
9/12snd-aoa: add build files for codecssound/aoa/codecs/Kconfig sound/aoa/codecs/Makefile+35 -00 replies
10/12snd-aoa: add layout-id fabricsound/aoa/fabrics/Kconfig sound/aoa/fabrics/Makefile sound/aoa/fabrics/snd-aoa-fabric-layout.c+1109 -00 replies
11/12snd-aoa: add Kconfig and Makefilesound/aoa/Kconfig sound/aoa/Makefile+21 -03 replies
12/12snd-aoa: wire up aoa in sound/sound/Kconfig sound/Makefile+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 00/12] snd-aoa: add snd-aoa

The following patches would add snd-aoa to the Linux source tree. I'm posting them here now for some last round of review before I finally post them with a Signed-Off-By and Changelog for inclusion. As you previously asked about this, I don't think it makes sense to commit these patches one by one, but the first one removing layout-id support from snd-powermac might be worth singling out.
Please let me know either way so that I provide either one or two changelog entries.

snd-aoa currently handles all Apple machines that have a layout-id property in the sound node in the device-tree and doesn't attempt to handle any others yet, a bunch of layout-ids are untested by users, support for those was added based on the Info.plist file OSX has.

The only thing that still needs to be done is getting it to work on the PowerMac7,2/7,3 where the device tree has a bug that apparently prevents the i2sbus module from working properly.

Also, the DRC feature of the tas3004 codec should be exposed like snd-powermac exposes it, so there'll probably be one more round of patches before I will finally ask for inclusion.

Other than that, it replaces snd-powermac for all layout-id machines, and handles many more already, so I have also added a patch to snd-powermac to this patchset that removes support for any machines with a layout-id it, allowing snd-aoa to take over for those machines even if both are compiled in. On affected machines, snd-powermac will also give the hint that snd-aoa should be used instead, but if snd-aoa is compiled as modules it will load automatically.

Thanks for previous review, I hope I have incorporated all suggestions. Over the previous version, the major change is adding the file core/snd-aoa-gpio-feature.c which contains GPIO access routines for those machine that don't have platform functions for it.

Any further comments are appreciated.

For the curious (like me :) ) here's a diffstat for the whole series:

 sound/Kconfig                                   |    2 
 sound/Makefile                                  |    2 
 sound/aoa/Kconfig                               |   17 
 sound/aoa/Makefile                              |    4 
 sound/aoa/aoa-gpio.h                            |   81 +
 sound/aoa/aoa.h                                 |  131 ++
 sound/aoa/codecs/Kconfig                        |   32 
 sound/aoa/codecs/Makefile                       |    3 
 sound/aoa/codecs/snd-aoa-codec-onyx.c           | 1113 ++++++++++++++++++++++++
 sound/aoa/codecs/snd-aoa-codec-onyx.h           |   76 +
 sound/aoa/codecs/snd-aoa-codec-tas-gain-table.h |  209 ++++
 sound/aoa/codecs/snd-aoa-codec-tas.c            |  653 ++++++++++++++
 sound/aoa/codecs/snd-aoa-codec-tas.h            |   47 +
 sound/aoa/codecs/snd-aoa-codec-toonie.c         |  140 +++
 sound/aoa/core/Makefile                         |    5 
 sound/aoa/core/snd-aoa-alsa.c                   |   98 ++
 sound/aoa/core/snd-aoa-alsa.h                   |   16 
 sound/aoa/core/snd-aoa-core.c                   |  156 +++
 sound/aoa/core/snd-aoa-gpio-feature.c           |  392 ++++++++
 sound/aoa/core/snd-aoa-gpio-pmf.c               |  246 +++++
 sound/aoa/fabrics/Kconfig                       |   12 
 sound/aoa/fabrics/Makefile                      |    1 
 sound/aoa/fabrics/snd-aoa-fabric-layout.c       | 1096 +++++++++++++++++++++++
 sound/aoa/soundbus/Kconfig                      |   14 
 sound/aoa/soundbus/Makefile                     |    3 
 sound/aoa/soundbus/core.c                       |  250 +++++
 sound/aoa/soundbus/i2sbus/Makefile              |    2 
 sound/aoa/soundbus/i2sbus/i2sbus-control.c      |  192 ++++
 sound/aoa/soundbus/i2sbus/i2sbus-control.h      |   37 
 sound/aoa/soundbus/i2sbus/i2sbus-core.c         |  387 ++++++++
 sound/aoa/soundbus/i2sbus/i2sbus-interface.h    |  187 ++++
 sound/aoa/soundbus/i2sbus/i2sbus-pcm.c          | 1017 +++++++++++++++++++++
 sound/aoa/soundbus/i2sbus/i2sbus.h              |  112 ++
 sound/aoa/soundbus/soundbus.h                   |  202 ++++
 sound/aoa/soundbus/sysfs.c                      |   43 
 sound/ppc/Makefile                              |    2 
 sound/ppc/pmac.c                                |   44 
 sound/ppc/pmac.h                                |    3 
 sound/ppc/powermac.c                            |    7 
 sound/ppc/toonie.c                              |  378 --------
 40 files changed, 6987 insertions(+), 425 deletions(-)

--