Skip to content

d80211: use sysfs instead of procfs

Jiri Benc netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12d80211: deinit sysfs in case of an errornet/d80211/ieee80211.c+1 -00 replies
2/12d80211: better sysfs registration of symlinks to wiphynet/d80211/ieee80211.c net/d80211/ieee80211_i.h net/d80211/ieee80211_iface.c +1 more+39 -410 replies
3/12d80211: separate allocation of ieee80211_localinclude/linux/netdevice.h net/d80211/ieee80211.c net/d80211/ieee80211_dev.c +10 more+206 -1672 replies
4/12d80211: fix Oops when writing to add_ and remove_ifacenet/d80211/ieee80211.c net/d80211/ieee80211_i.h net/d80211/ieee80211_sysfs.c+28 -40 replies
5/12d80211: wiphy sysfs attributesnet/d80211/ieee80211_proc.c net/d80211/ieee80211_proc.h net/d80211/ieee80211_sysfs.c+302 -90 replies
6/12d80211: network interface sysfs attributesnet/d80211/ieee80211_i.h net/d80211/ieee80211_iface.c net/d80211/ieee80211_sysfs.c+301 -20 replies
7/12d80211: rename sta_info_relase to sta_info_putnet/d80211/ieee80211.c net/d80211/ieee80211_iface.c net/d80211/ieee80211_ioctl.c +4 more+31 -310 replies
8/12d80211: sysfs attributes for associated stationsnet/d80211/Makefile net/d80211/ieee80211.c net/d80211/ieee80211_i.h +4 more+331 -450 replies
9/12d80211: remove useless parametersnet/d80211/ieee80211.c net/d80211/ieee80211_iface.c net/d80211/ieee80211_ioctl.c +4 more+37 -380 replies
10/12d80211: rate_control sysfs attributesnet/d80211/ieee80211.c net/d80211/rate_control.c net/d80211/rate_control.h +1 more+94 -10 replies
11/12d80211: encryption keys sysfs attributesnet/d80211/ieee80211.c net/d80211/ieee80211_i.h net/d80211/ieee80211_ioctl.c +3 more+326 -390 replies
12/12d80211: remove procfs filesnet/d80211/Makefile net/d80211/ieee80211.c net/d80211/ieee80211_iface.c +6 more+32 -8740 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/12] d80211: use sysfs instead of procfs

The following series of patches makes d80211 to use sysfs instead of procfs. This means that custom reference counting in most structures is replaced by kobjects and nearly all informations from procfs files are converted to sysfs attributes.

The only information missing in sysfs (compared to procfs) is channels and rates info. Implementing this in a sysfs way (i. e. one information per attribute rule) requires a lot of code and (more important) adding kobjects to channel and rate structures. I doubt these informations are really so useful to be worth such complications. If there are good arguments why these informations should be exported via sysfs I will add them.

If you find a better name for some object (directory) or attribute (file) or just consider some name wrong or ugly, let me know please.

The third patch ("separate allocation of ieee80211_local") touches the code outside of net/d80211 - it adds ieee80211_ptr to net_device structure.

All of patches can be also obtained from 'master' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jbenc/dscape.git

---

Jiri Benc:
d80211: deinit sysfs in case of an error
d80211: better sysfs registration of symlinks to wiphy
d80211: separate allocation of ieee80211_local
d80211: fix Oops when writing to add_ and remove_iface
d80211: wiphy sysfs attributes
d80211: network interface sysfs attributes
d80211: rename sta_info_relase to sta_info_put
d80211: sysfs attributes for associated stations
d80211: remove useless parameters
d80211: rate_control sysfs attributes
d80211: encryption keys sysfs attributes
d80211: remove procfs files

 include/linux/netdevice.h        |    1 
 net/d80211/Makefile              |    2 
 net/d80211/ieee80211.c           |  206 +++++++---
 net/d80211/ieee80211_dev.c       |   17 +
 net/d80211/ieee80211_i.h         |   45 ++
 net/d80211/ieee80211_iface.c     |   43 +-
 net/d80211/ieee80211_ioctl.c     |  213 ++++++----
 net/d80211/ieee80211_key.h       |    2 
 net/d80211/ieee80211_proc.c      |  771 --------------------------------------
 net/d80211/ieee80211_proc.h      |   45 --
 net/d80211/ieee80211_scan.c      |   10 
 net/d80211/ieee80211_sta.c       |   68 ++-
 net/d80211/ieee80211_sysfs.c     |  706 +++++++++++++++++++++++++++++++++--
 net/d80211/ieee80211_sysfs_sta.c |  434 +++++++++++++++++++++
 net/d80211/rate_control.c        |   55 ++-
 net/d80211/rate_control.h        |   57 ++-
 net/d80211/sta_info.c            |  132 ++++---
 net/d80211/sta_info.h            |   16 -
 net/d80211/wme.c                 |   26 +
 19 files changed, 1663 insertions(+), 1186 deletions(-)
Signature · 2 lines
Jiri Benc
SUSE Labs