RFC Mount writer count and read-only bind mounts (v2)
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest20 patches 15 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/20 | prepare for write access checks: collapse if()fs/ fs/ | +64 | 0 replies | |
| 2/20 | r/o bind mount prepwork: move open_namei()'s vfs_create()fs/ | +20 | 0 replies | |
| 3/20 | Add vfsmount writer countfs/ include/ | +50 | 4 replies | |
| 4/20 | elevate mnt writers for callers of vfs_mkdir()fs/ fs/ | +9 | 0 replies | |
| 5/20 | elevate write count during entire ncp_ioctl()fs/ | +54 | 0 replies | |
| 6/20 | sys_symlinkat() elevate write count around vfs_symlink()fs/ | +5 | 0 replies | |
| 7/20 | elevate mount count for extended attributesfs/ fs/ | +20 | 0 replies | |
| 8/20 | sys_linkat(): elevate write count around vfs_link()fs/ | +5 | 0 replies | |
| 9/20 | mount_is_safe(): add commentfs/ | +4 | 0 replies | |
| 10/20 | unix_find_other() elevate write count for touch_atime()net/ | +12 | 0 replies | |
| 11/20 | elevate write count over calls to vfs_rename()fs/ fs/ | +15 | 2 replies | |
| 12/20 | tricky: elevate write count files are open()edfs/ fs/ ipc/ | +25 | 0 replies | |
| 13/20 | elevate writer count for do_sys_truncate()fs/ | +11 | 0 replies | |
| 14/20 | elevate write count for do_utimes()fs/ | +9 | 0 replies | |
| 15/20 | elevate write count for do_sys_utime() and touch_atime()fs/ fs/ | +18 | 0 replies | |
| 16/20 | sys_mknodat(): elevate write count for vfs_mknod/create()fs/ fs/ net/ | +20 | 0 replies | |
| 17/20 | elevate mnt writers for vfs_unlink() callersfs/ ipc/ | +8 | 0 replies | |
| 18/20 | do_rmdir(): elevate write countfs/ | +5 | 0 replies | |
| 19/20 | elevate writer count for custom 'struct file'fs/ mm/ mm/ +1 more | +9 | 0 replies | |
| 20/20 | honor r/w changes at do_remount() timefs/ fs/ include/ | +26 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC][PATCH 00/20] Mount writer count and read-only bind mounts (v2)
The following series implements read-only bind mounts. This feature allows a read-only view into a read-write filesystem. In the process of doing that, it also provides infrastructure for keeping track of the number of writers to any given mount. New in this version is that if that number is non-zero, remounts from r/w to r/o are not allowed.
This set does not take the previously tried approach of pushing down the vfsmount structure deeply into call paths, such that it might be checked in functions like permission(), may_create() and may_open(). Instead, it does checks near the entry points in the kernel, bumping a reference count in the vfsmount structure. I've also eliminated the use of the MNT_RDONLY flag. It was redundant since we have the reference count.
This set also makes no attempt to keep the return codes for these r/o bind mounts the same as for a real r/o filesystem or device. It would require significantly more code and be quite a bit more invasive. Unless there is a very strong reason to do so, I believe it isn't worth the trouble.
One note: the previous patches all worked this way:
mount --bind -o ro /source /dest
These patches have changed that behavior. It now requires two steps:
mount --bind /source /dest mount -o remount,ro /dest
If this set goes OK, I think it is time for a trip through -mm.