Skip to content

Improve MSI detection v2

Brice Goglin lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8Rename PCI_CAP_ID_HT_IRQCONF into PCI_CAP_ID_HTarch/powerpc/sysdev/mpic.c include/linux/pci_regs.h+2 -20 replies
2/8Factorize common MSI detection code from pci_enable_msi() and msix()drivers/pci/msi.c+26 -200 replies
3/8Blacklist PCI-E chipsets depending on Hypertransport MSI capabalitydrivers/pci/quirks.c include/linux/pci_ids.h+66 -00 replies
4/8Stop inheriting bus flags and check root chipset bus flags insteaddrivers/pci/msi.c drivers/pci/probe.c include/linux/pci.h+11 -60 replies
5/8Whitelist non-PCI-E chipsets that are known to support MSIdrivers/pci/quirks.c include/linux/pci.h+13 -00 replies
6/8Disable MSI by default on non-PCI-E chipsetdrivers/pci/msi.c+10 -40 replies
7/8Drop existing quirks that disable MSI on some non PCI-E chipsetsdrivers/pci/quirks.c+0 -130 replies
8/8Drop pci_msi_quirkdrivers/pci/msi.c drivers/pci/pci.h drivers/pci/quirks.c+0 -150 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] Improve MSI detection v2

[PATCH 0/8] Improve MSI detection v2

After my proposal to whitelist chipsets supporting MSI a couple days ago, here's a patchset implementing what seemed to better suit what people replied. We enable MSI by default on PCI-E and disable on non-PCI-E chipsets.

#1 - Rename PCI_CAP_ID_HT_IRQCONF to PCI_CAP_ID_HT
#2 - Factorize common MSI detection code from pci_enable_msi() and msix() #3 - Blacklist PCI-E chipsets depending on Hypertransport MSI capabality #4 - Stop inheriting bus flags and check root chipset bus flags instead #5 - Whitelist Intel PCI chipsets that are known to support MSI #6 - Disable MSI by default on non PCI-E chipsets
#7 - Drop existing quirks that disable MSI on some non PCI-E chipsets #8 - Drop pci_msi_quirk

#1 to #4 are simple and could make it to 2.6.18 easily.
#6 might need the list of whitelisted chipsets to be improved to avoid regressions (nVidia chipsets for Intel processors?).
#5 is useless without #6.
#7 and #8 are mainly cosmetic (remove obsolete stuff when the new model is in place).

These patches are against 2.6.17-rc6-mm2.

I did not keep the option "pci=forcemsi" since it makes less sense than in my previous RFC. But I'd be happy to reimplement it, or even something at the device granularity.

Brice Goglin