Skip to content

aic7xxx: remove excessive inlining

Denis Vlasenko linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4aic7xxx: remove excessive inlining+0 -00 replies
2/4aic7xxx: remove excessive inlining+0 -00 replies
3/4aic7xxx: remove excessive inlining+0 -01 reply
4/4aic7xxx: remove excessive inliningdrivers/scsi/aic7xxx/aic79xx_core.c+3 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/4] aic7xxx: remove excessive inlining

Hello,

This is a resend. I had these patches run-tested at the time of first submission. Now I have no hardware to test them. I think that they are still fine, though.

Basically, patches deinline some functions, mainly those which perform port I/O. They shave off ~55k on AMD64:

# x86_64-pc-linux-gnu-size linux-2.6.17.8_64*/vmlinux
   text    data     bss     dec     hex filename
4632627 1222698  468392 6323717  607e05 linux-2.6.17.8_64/vmlinux
4571327 1223274  468392 6262993  5f90d1 linux-2.6.17.8_64aic/vmlinux
# x86_64-pc-linux-gnu-size linux-2.6.17.8_64*/drivers/scsi/aic7xxx/aic7*xx.o
   text    data     bss     dec     hex filename
 135543   13521     628  149692   248bc linux-2.6.17.8_64/drivers/scsi/aic7xxx/aic79xx.o
 103291   22289     560  126140   1ecbc linux-2.6.17.8_64/drivers/scsi/aic7xxx/aic7xxx.o
  90083   13521     628  104232   19728 linux-2.6.17.8_64aic/drivers/scsi/aic7xxx/aic79xx.o
  87231   22289     560  110080   1ae00 linux-2.6.17.8_64aic/drivers/scsi/aic7xxx/aic7xxx.o
--
vda