C cleanup series, mostly nasty shadowing
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest7 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/7 | avoid to use error that shadows the function name, use err instead.builtin-apply.c builtin-push.c | +8 | 0 replies | |
| 2/7 | git_dir holds pointers to local strings, hence MUST be const.cache.h environment.c | +5 | 0 replies | |
| 3/7 | missing 'static' keywordsbuiltin-tar-tree.c http-push.c | +2 | 0 replies | |
| 4/7 | remove ugly shadowing of loop indexes in subloops.builtin-mv.c git.c | +6 | 0 replies | |
| 5/7 | missing #define DEBUG 0 that made the preprocessor whinebuiltin-grep.c | +2 | 0 replies | |
| 6/7 | use name[len] in switch directly, instead of creating a shadowed variable.builtin-apply.c | +1 | 0 replies | |
| 7/7 | n is in fact unused, and is later shadowed.date.c | +2 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/7] C cleanup series, mostly nasty shadowing
This series of patches intend to fix some not very nice bits of code. None of them are critical though.
0001-avoid-to-use-error-that-shadows-the-function-name-use-err-instead.txt 0002-git_dir-holds-pointers-to-local-strings-hence-MUST-be-const.txt 0003-missing-static-keywords.txt 0004-remove-ugly-shadowing-of-loop-indexes-in-subloops.txt 0005-missing-define-DEBUG-0-that-made-the-preprocessor-whine.txt 0006-use-name-len-in-switch-directly-instead-of-creating-a-shadowed-variable.txt 0007-n-is-in-fact-unused-and-is-later-shadowed.txt
builtin-apply.c | 10 ++++------ builtin-grep.c | 2 ++ builtin-mv.c | 6 +++--- builtin-push.c | 10 +++++----- builtin-tar-tree.c | 2 +- cache.h | 2 +- date.c | 5 ++--- environment.c | 7 ++++--- git.c | 6 +++--- http-push.c | 2 +- 10 files changed, 26 insertions(+), 26 deletions(-)
Signature · 3 lines
·O· Pierre Habouzit ··O [email protected] OOO http://www.madism.org