Skip to content

RFC dio: clean up completion phase of direct_io_worker()

Zach Brown linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5dio: centralize completion in dio_complete()fs/direct-io.c+42 -520 replies
2/5dio: call blk_run_address_space() once per opfs/direct-io.c+3 -50 replies
3/5dio: formalize bio counters as a dio reference countfs/direct-io.c+66 -740 replies
4/5dio: remove duplicate bio wait codefs/direct-io.c+12 -290 replies
5/5dio: only call aio_complete() after returning -EIOCBQUEUEDfs/direct-io.c mm/filemap.c+36 -600 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC 0/5] dio: clean up completion phase of direct_io_worker()

dio: clean up completion phase of direct_io_worker()

There have been a lot of bugs recently due to the way direct_io_worker() tries to decide how to finish direct IO operations. In the worst examples it has failed to call aio_complete() at all (hang) or called it too many times (oops).

This set of patches cleans up the completion phase with the goal of removing the complexity that lead to these bugs. We end up with one path that calculates the result of the operation after all off the bios have completed. We decide when to generate a result of the operation using that path based on the final release of a refcount on the dio structure.

I tried to progress towards the final state in steps that were relatively easy to understand. Each step should compile but I only tested the final result of having all the patches applied.

The patches result in a slight net decrease in code and binary size:

 2.6.18-rc4-dio-cleanup/fs/direct-io.c |    8
 2.6.18-rc5-dio-cleanup/fs/direct-io.c |   94 +++++------
 2.6.18-rc5-dio-cleanup/mm/filemap.c   |    4
 fs/direct-io.c                        |  273 ++++++++++++++--------------------
 4 files changed, 159 insertions(+), 220 deletions(-)

text data bss dec hex filename

2592385  450996  210296 3253677  31a5ad vmlinux.before
2592113  450980  210296 3253389  31a48d vmlinux.after

The patches pass light testing with aio-stress, the direct IO tests I could manage to get running in LTP, and some home-brew functional tests. It's still making its way through stress testing. It should not be merged until we hear from that more rigorous testing, I don't think.

I hoped to get some feedback (and maybe volunteers for testing!) by sending the patches out before waiting for the stress tests.

- z