pcnet32: NAPI implementation (one more try)
Status from this message: applied patches 1-5, thanks.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/5 | pcnet32: remove unnecessary save/restore register accesses.drivers/ | +1 | 1 reply | |
| 2/5 | pcnet32: magic number cleanupdrivers/ | +30 | 0 replies | |
| 3/5 | pcnet32: move/create receive and transmit routinesdrivers/ | +259 | 0 replies | |
| 4/5 | pcnet32: break receive routine into two pieces.drivers/ | +140 | 0 replies | |
| 5/5 | pcnet32: NAPI implementationdrivers/ drivers/ | +121 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/5] pcnet32: NAPI implementation (one more try)
These patches to the pcnet32 driver implement NAPI and respond to some other suggestions found during NAPI development and testing.
The first patch deletes a couple of unnecessary save/restore operations. The second patch replaces some magic numbers with hopefully more clear defines.
The third patch moves the receive and creates a transmit routine. The fourth patch breaks the receive routine into two pieces to make the code easier to read and simpler.
The fifth and final patch implements the NAPI changes.
The comments from Francois Romieu regarding using spin_lock instead of spin_lock_irqsave were investigated, but since interrupts have to be disabled to prevent the interrupt handler from deadlocking, and since I would probably forget sometime, it is safer to leave the locking as it is. The requested mmiowb calls were added.
Please appply to 2.6.19.
[PATCH 1/5] pcnet32: remove unnecessary save/restore register accesses. [PATCH 2/5] pcnet32: magic number cleanup [PATCH 3/5] pcnet32: move/create receive and transmit routines [PATCH 4/5] pcnet32: break receive routine into two pieces. [PATCH 5/5] pcnet32: NAPI implementation
Signature · 2 lines
Don Fry [email protected]