Skip to content

gitweb: A few code cleanup patches

Jakub Narebski git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 4 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5gitweb: Strip trailing slashes from $path in git_get_hash_by_pathgitweb/gitweb.perl+1 -10 replies
2/5gitweb: Use "return" instead of "return undef" for some subsgitweb/gitweb.perl+2 -20 replies
3/5gitweb: Split validate_input into validate_pathname and validate_refnamegitweb/gitweb.perl+50 -162 replies
4/5gitweb: Add git_url subroutine, and use it to quote full URLsgitweb/gitweb.perl+10 -10 replies
5/5gitweb: Quote filename in HTTP Content-Disposition: headergitweb/gitweb.perl+9 -82 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] gitweb: A few code cleanup patches

This series of patches, based on 8391548e5e78677eb81f97334d998418802ea194 adds some code cleanups (including validating input and escaping output). Most deals with changes introduced in
[PATCH] gitweb: Consolidate escaping/validation of query string commit a2f3db2f5de2a3667b0e038aa65e3e097e642e7d (by Petr Baudis)
Message-ID: <20060923221841.18063.56589.stgit@rover>

Shortlog:
[PATCH 1/5] gitweb: Strip trailing slashes from $path in git_get_hash_by_path [PATCH 2/5] gitweb: Use "return" instead of "return undef" for some subs [PATCH 3/5] gitweb: Split validate_input into validate_pathname and validate_refname [PATCH 4/5] gitweb: Add git_url subroutine, and use it to quote full URLs [PATCH 5/5] gitweb: Quote filename in HTTP Content-Disposition: header

Diffstat:

 gitweb/gitweb.perl |  100 +++++++++++++++++++++++++++++++++++++---------------
 1 files changed, 72 insertions(+), 28 deletions(-)
Signature · 3 lines
Jakub Narebski
ShadeHawk on #git
Warsaw, Poland