Skip to content

: powerpc/cell spidernet bugfixes, etc.

Linas Vepstas linuxppc-dev lkml netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest21 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/21: powerpc/cell spidernet ethtool -i version number info.drivers/net/spider_net.c drivers/net/spider_net.h drivers/net/spider_net_ethtool.c+6 -10 replies
2/21: powerpc/cell spidernet burst alignment patch.drivers/net/spider_net.h+1 -10 replies
3/21: Spidernet module parm permissionsdrivers/net/spider_net.c+2 -20 replies
4/21: powerpc/cell spidernet force-end fixdrivers/net/spider_net.c+4 -10 replies
5/21: powerpc/cell spidernet zlen min packet lengthdrivers/net/spider_net.c+14 -40 replies
6/21: powerpc/cell spidernet add missing netdev watchdogdrivers/net/spider_net.c+1 -00 replies
7/21: Spidernet fix register field definitionsdrivers/net/spider_net.c drivers/net/spider_net.h+12 -60 replies
8/21: Spidernet stop queue when queue is full.drivers/net/spider_net.c+10 -230 replies
9/21: powerpc/cell spidernet bogus rx interrupt bitdrivers/net/spider_net.h+2 -30 replies
10/21: powerpc/cell spidernet fix error interrupt printdrivers/net/spider_net.c+1 -10 replies
11/21: powerpc/cell spidernet stop error printing patch.drivers/net/spider_net.c+9 -40 replies
12/21: powerpc/cell spidernet incorrect offsetdrivers/net/spider_net.c+3 -10 replies
13/21: powerpc/cell spidernet low watermark patch.drivers/net/spider_net.c drivers/net/spider_net.h+47 -40 replies
14/21: powerpc/cell spidernet NAPI polling info.drivers/net/spider_net.c+8 -80 replies
15/21: powerpc/cell spidernet refine lockingdrivers/net/spider_net.c+43 -520 replies
16/21: powerpc/cell spidernetdrivers/net/spider_net.c+0 -20 replies
17/21: powerpc/cell spidernet reduce DMA kickingdrivers/net/spider_net.c+13 -60 replies
18/21: powerpc/cell spidernet variable name changedrivers/net/spider_net.c drivers/net/spider_net.h drivers/net/spider_net_ethtool.c+10 -100 replies
19/21: powerpc/cell spidernet DMA direction fixdrivers/net/spider_net.c+13 -130 replies
20/21: powerpc/cell spidernet release all descrsdrivers/net/spider_net.c+2 -20 replies
21/21: powerpc/cell spidernet DMA coalescingdrivers/net/spider_net.c drivers/net/spider_net.h+59 -648 replies

Reviews trailers per patch

6 of 21 patches have a Reviewed-by or Acked-by.

PatchArnd BergmannJoel Schopp
1/21A-b
2/21A-b
3/21
4/21
5/21
6/21
7/21
8/21
9/21
10/21
11/21A-b
12/21
13/21A-b
14/21A-b
15/21
16/21
17/21
18/21
19/21
20/21
21/21A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/21]: powerpc/cell spidernet bugfixes, etc.

Andrew, please apply/forward upstream.

The following set of 21 patches (!) are all aimed at the the spidernet ethernet device driver. The spidernet is an etherenet controller built into the Toshiba southbridge for the PowerPC Cell processor. (This is the only device in existance that with this ethernet hardware in it).

These patches re-package/re-order/re-cleanup a previous set of patches I've previously mailed. Thus, some have been previously Acked-by lines, most do not. Most of these patches are tiny, and handle problems that cropped up during testing. Sorry about there being so many of them.

The first set of 12 patches fix a large variety of mostly minor bugs.

The important patches are 13 through 17: these overcome a debilitating performance problem on transmit (6 megabits per second !!) on transmit of patches 500 bytes or larger. After applying these, I am able to get the following:

pkt sz   speed (100K buffs)       speed (4M buffs)
------   -----------------        ----------------
1500     700 Mbits/sec            951 Mbits/sec
1000     658 Mbits/sec            770
800      600                      648
500      500                      500
300      372                      372

60 70 70

Above buf size refers to /proc/sys/net/core/wmem_default

----

I'm not planning on any further patches for a long while. I tried to do som RX work, but gave up. RX performance could be improved.

FYI, Christoph Hellwig's node-aware patches seem to make no difference at all any more.

I tried to base these on linux-2.6.19-rc1-mm1 but hit a kernel BUG in copy_fdtable at fs/file.c:138! (reported earlire today by Olof)

--linas