Skip to content

On demand sched_domain balancing in tasklet

Christoph Lameter lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5Disable interrupts for locking in load_balance()kernel/sched.c+6 -50 replies
2/5Extract load calculation from rebalance_tickkernel/sched.c+63 -502 replies
3/5Use next_balance instead of last_balanceinclude/asm-i386/topology.h include/asm-ia64/topology.h include/asm-mips/mach-ip27/topology.h +5 more+19 -215 replies
4/5Create rebalance_domains from rebalance_tickkernel/sched.c+18 -222 replies
5/5Only call rebalance_domains when needed from scheduler_tickkernel/sched.c+12 -24 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] On demand sched_domain balancing in tasklet

This patchset moves potentially expensive load balancing out of the scheduler tick (where we run with interrupts disabled) into a tasklet that is triggered if necessary from scheduler_tick(). Load balancing will then run with interrupts enabled. This eliminates interrupt holdoff times and avoids potential machine livelock if f.e. load balancing is performed over a large number of processors and many of the nodes experience heavy load which may lead to delays in fetching cachelines. We have currently up to 1024 processors and may go up to 4096 soon. Similar issues were seen on a Fujitsu system in the past.

The moving of the load balancing into a tasklet also allows some cleanup in scheduler_tick(). It gets easier to read and the determination of the state for load balancing can be moved out of scheduler_tick().

Further optimization of scheduler_tick() processing occurs because we no longer check all the sched domains on each tick.
We determine the time of the next load balancing on every load balancing and check against this single value in scheduler_tick().

Another optimization is that we perform the staggering of the individual load balance operations not during load balancing but shift that to the setup of the sched domains.

For the earlier discussion see:
http://marc.theaimsgroup.com/?t=116119187800002&r=1&w=2

Tested on:
NUMA ia64/sn2
SMP i386
UP x86_64