Skip to content

sched_domain balancing via tasklet V2

Christoph Lameter lkml 1 version In review

Get series with b4
b4 am 20061028024112.10809.15841.sendpatchset@schroedinger.engr.sgi.com

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Avoid taking rq lock in wake_priority_sleeperkernel/sched.c+3 -00 replies
2/7Disable interrupts for locking in load_balance()kernel/sched.c+6 -50 replies
3/7Extract load calculation from rebalance_tickkernel/sched.c+60 -480 replies
4/7Stagger load balancing in build_sched_domainskernel/sched.c+17 -90 replies
5/7Move idle stat calculation into rebalance_tick()kernel/sched.c+16 -212 replies
6/7Use tasklet to call balancingkernel/sched.c+15 -40 replies
7/7Call tasklet less frequentlykernel/sched.c+22 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] sched_domain balancing via tasklet V2

This patchset moves potentially expensive load balancing out of the scheduler tick (where we run with interrupts disabled) into a tasklet that is triggered if necessary from scheduler_tick(). Load balancing will then run with interrupts enabled. This eliminates interrupt holdoff times and avoids potential machine livelock if f.e. load balancing is performed over a large number of processors and many of the nodes experience heavy load which may lead to delays in fetching cachelines. We have currently up to 1024 processors and may go up to 4096 soon. Similar issues were seen on a Fujitsu system in the past.

However, this issue also highlights the general problem of interrupt holdoff during scheduler load balancing.

The moving of the load balancing into a tasklet also allows some cleanup in scheduler_tick(). It gets easier to read and the determination of the state for load balancing can be moved out of scheduler_tick().

Further optimization of scheduler_tick() processing occurs because we no longer check all the sched domains on each tick.
We determine the time of the next load balancing on every load balancing and check against this single value in scheduler_tick().

Another optimization is that we perform the staggering of the individual load balance operations not during load balancing but shift that to the setup of the sched domains.

For the earlier discussion see:
http://marc.theaimsgroup.com/?t=116119187800002&r=1&w=2
V1: http://marc.theaimsgroup.com/?l=linux-kernel&m=116171494001548&w=2

V1-V2:
- Keep last_balance and calculate the next balancing from that start point.
- Move more code into time_slice calculation and rename time_slice() to task_running_tick().
- Separate out the wake_priority_sleeper optimization as a first patch.