Skip to content

Syslog permissions, revised

Zack Weinberg lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Add <linux/klog.h>fs/proc/kmsg.c include/linux/Kbuild include/linux/klog.h +1 more+47 -310 replies
2/4permission mapping for sys_syslog operationsinclude/linux/klog.h kernel/printk.c security/commoncap.c +2 more+51 -256 replies
3/4Refactor do_syslog interfacefs/proc/kmsg.c include/linux/klog.h kernel/printk.c+145 -1180 replies
4/4Distinguish /proc/kmsg access from sys_syslogfs/proc/kmsg.c include/linux/klog.h security/commoncap.c +1 more+20 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/4] Syslog permissions, revised

This patchset revises my attempt from last week to allow running klogd unprivileged without a root shim. I believe I have addressed all outstanding objections: in particular, the privilege model enforced by SELinux is unchanged (you have to have system__syslog_mod to read /proc/kmsg). I have also included some nice refactorings (symbolic constants for sys_syslog opcodes, that sort of thing) and a few bugfixes (minor and unlikely to affect any live application, but still).

I hope that this can be considered for 2.6.19; it is low risk in my opinion and it would be nice to get this functionality into the hands of the distributors sooner.

zw