Skip to content

: Retransmission & Sequence Numbers

Gerrit Renker dccp 1 version In review

Get series with b4
b4 am 200611131327.24492@strip-the-willow

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7: Update retransmit timer commentsnet/dccp/timer.c+6 -40 replies
2/7: Increment sequence numbers on retransmitted Response packetsnet/dccp/minisocks.c net/dccp/output.c+13 -70 replies
3/7: Add sysctls to control retransmission behaviourDocumentation/networking/dccp.txt include/linux/sysctl.h net/dccp/dccp.h +3 more+91 -130 replies
4/7: Introduce a consistent naming scheme for sysctlsnet/dccp/dccp.h net/dccp/ipv4.c net/dccp/minisocks.c +2 more+32 -330 replies
5/7: Remove forward declarations in timer.cnet/dccp/timer.c+53 -570 replies
6/7: Remove redundant statements in init_sequencenet/dccp/ipv4.c net/dccp/ipv6.c+8 -170 replies
7/7: Choose a genuine initial DCCPv6 sequence numbernet/dccp/ipv4.c net/dccp/output.c+7 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7]: Retransmission & Sequence Numbers

This is one medium-sized patch (20k),
split into 7 piecemeal chunks.

Patch 1: Update comments on precisely which packets can be retransmitted
Program documentation

Patch 2: Increment sequence numbers on retransmitted Response packets
As per http://www.mail-archive.com/[email protected]/msg00659.html

Patch 3: Add sysctls to control retransmission behaviour

Patch 4: Introduce a consistent naming scheme for sysctls
As in TCP, DCCP sysctls have all been prefixed with sysctl_dccp_xxx.

Patch 5: Remove forward declarations in timer.c
Another few forward declarations erased.

Patch 6: Remove redundant statements in init_sequence (ISS)
Removes dead code - a similar patch has been accepted for TCP.

Patch 7: Choose a real initial sequence number
Is a DCCPv6 fix: so far, no ISS was chosen.

I have uploaded these as series `11' (1..7 map to a..f) onto
http://www.erg.abdn.ac.uk/users/gerrit/dccp/patch-backlog/

Ian what about your memsysctl patches - it would be useful to have them and I could change patch 3/4 to match that, but they have not been submitted yet.

-- Gerrit