Skip to content

: Netfilter -stable fixes

Patrick McHardy netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8: Missing check for CAP_NET_ADMIN in iptables compat layernet/ipv4/netfilter/ip_tables.c+3 -00 replies
2/8: ip_tables: compat error way cleanupnet/ipv4/netfilter/ip_tables.c+1 -00 replies
3/8: ip_tables: fix module refcount leaks in compat error pathsnet/ipv4/netfilter/ip_tables.c+19 -170 replies
4/8: Missed and reordered checks in {arp, ip, ip6}_tablesnet/ipv4/netfilter/arp_tables.c net/ipv4/netfilter/ip_tables.c net/ipv6/netfilter/ip6_tables.c+54 -250 replies
5/8: arp_tables: missing unregistration on module unloadnet/ipv4/netfilter/arp_tables.c+2 -00 replies
6/8: Honour source routing for LVS-NATinclude/linux/netfilter_ipv4.h net/ipv4/ipvs/ip_vs_core.c net/ipv4/netfilter.c +2 more+21 -60 replies
7/8: Kconfig: fix xt_physdev dependenciesnet/netfilter/Kconfig+1 -10 replies
8/8: xt_CONNSECMARK: fix Kconfig dependenciesnet/netfilter/Kconfig+3 -10 replies

Reviews trailers per patch

3 of 8 patches have a Reviewed-by or Acked-by.

PatchDmitry MishinKirill KorotaevVasily Averin
1/8
2/8A-b A-b
3/8A-b A-b
4/8A-b
5/8
6/8
7/8
8/8

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v1 thread

Cover letter [NETFILTER 00/08]: Netfilter -stable fixes

Following are backports of a few important netfilter fixes for -stable, fixing multiple bugs in the ip_tables compat layer, missing checks during ip_tables ruleset validation and a crash on arp_tables module unload/reload. Also included are two patches fixing incorrect Kconfig dependencies and a LVS NAT source routing fix.

Please apply, thanks.

 include/linux/netfilter_ipv4.h         |    2 
 net/ipv4/ipvs/ip_vs_core.c             |   10 ++++
 net/ipv4/netfilter.c                   |    9 ++--
 net/ipv4/netfilter/arp_tables.c        |   27 ++++++++----
 net/ipv4/netfilter/ip_nat_standalone.c |    3 -
 net/ipv4/netfilter/ip_tables.c         |   70 +++++++++++++++++++++------------
 net/ipv4/netfilter/iptable_mangle.c    |    3 -
 net/ipv6/netfilter/ip6_tables.c        |   24 +++++++----
 net/netfilter/Kconfig                  |    6 +-
 9 files changed, 104 insertions(+), 50 deletions(-)

Patrick McHardy:
[NETFILTER]: ip_tables: missing check for CAP_NET_ADMIN in compat layer [NETFILTER]: ip_tables: compat error way cleanup [NETFILTER]: ip_tables: fix module refcount leaks in compat error paths [NETFILTER]: Missed and reordered checks in {arp,ip,ip6}_tables [NETFILTER]: arp_tables: missing unregistration on module unload [NETFILTER]: Honour source routing for LVS-NAT
[NETFILTER]: Kconfig: fix xt_physdev dependencies [NETFILTER]: xt_CONNSECMARK: fix Kconfig dependencies