Skip to content

RFC : CCID 3 updates

Gerrit Renker dccp 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am 200611241619.04691@strip-the-willow

Versions newest first

  1. v1 RFC Latest10 patches 30 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/10: Avoid congestion control on zero-sized data packetsnet/dccp/ccids/ccid3.c+5 -92 replies
2/10: Remove redundant statements in ccid3_hc_tx_packet_sentnet/dccp/ccids/ccid3.c+0 -212 replies
3/10: Resolve small FIXMEnet/dccp/ccids/ccid3.c+4 -52 replies
4/10: Consolidate timer resetsnet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h+10 -101 reply
5/10: Consistently update t_nom, t_ipi, t_deltanet/dccp/ccids/ccid3.c+15 -214 replies
6/10: Consolidate handling of t_RTOnet/dccp/ccids/ccid3.c+14 -152 replies
7/10: Avoid `division by zero' errorsnet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h net/dccp/ccids/lib/tfrc_equation.c+33 -294 replies
8/10: Larger initial windowsnet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h+43 -343 replies
9/10: Add documentation for TFRC structuresinclude/linux/tfrc.h+18 -22 replies
10/10: Simplify dccp_rcv_state_processnet/dccp/input.c+17 -172 replies

Reviews trailers per patch

4 of 10 patches have a Reviewed-by or Acked-by.

PatchIan McDonald
1/10
2/10A-b
3/10
4/10
5/10A-b
6/10A-b
7/10
8/10A-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/10] [RFC]: CCID 3 updates

I have cut this into 10 small pieces to make reviewing easier.

If everyone is happy with it, I can re-send it as one piece.

I have compile-tested all patches but I think CCID 3 needs some more (other) work and then some performance-testing.

Patch 1: Avoid congestion control on zero-sized data packets.
Sending zero-sized Data/DataAck packets is theoretically possible, but just makes trouble for CCID 3. This patch changes the error code and removes one message which always gets printed.

Patch 2: Remove redundant statements in ccid3_hc_tx_packet_sent.
An analysis showed that one statement can be removed.

Patch 3: Resolves a small FIXME (Acks when nothing has been sent).

Patch 4: Consolidate timer resets.
This considers calculating the nofeedback timeout when no feedback has previously been received. It applies common sense, since RFC 3448 is not clear about this case (it recommends to use max(4*R, 2*s/X), but R is still undefined due to section 4.2)

Patch 5: Consistently update t_nom, t_ipi, t_delta.
This, like the other patches, results from the earlier analysis and exploits the dependencies among variables.

Patch 6: Consolidate handling of t_RTO.
This updates several things related to t_RTO and nofeedback timeout, exploiting yet another dependency.
And it adds a FIXME: currently the way it is calculated is non-standard.
The code does t_RTO = max(4*R, 1 second)
nofeedback_timeout = max(t_RTO, 2 * s/X)
(RFC 3448: nofeedback_timeout = max(4 * R, 2 * s/X) )
I have asked my colleague about it - is it good or bad to keep it this way???

Patch 7: Avoid `division by zero' errors.
This adds the protection against dividing a zero RTT for the sender. I believe that this could be further improved - with regard to malfunctioning timestamps.

Patch 8: Larger initial windows.
This implements the larger-initial-windows feature for CCID 3, as per [RFC 4342, 5.]

Patch 9: Add documentation for the TFRC structure fields (in include/linux/tfrc.h).
==> Here I have a suggestion.
The only, single source code file
which currently includes include/linux/tfrc.h
is net/dccp/ccids/lib/tfrc_equation.c
Maybe it would be a good
idea to merge include/linux/tfrc.h
with net/dccp/ccids/lib/tfrc.h
(also included by net/dccp/ccids/lib/tfrc_equation.c ),
since net/dccp/ccids/lib/tfrc.h
is currently almost empty ???

Patch 10: Simplify dccp_rcv_state_process.
This adds a minor simplification in the control flow.

-- Gerrit