Skip to content

RFC : Clean-ups

Gerrit Renker dccp 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am 200611281430.01278@strip-the-willow

Versions newest first

  1. v1 RFC Latest2 patches 22 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/2: Remove small typonet/dccp/ccids/ccid3.c+2 -26 replies
2/2: Use `unsigned' for packet lengthsnet/dccp/ccid.h net/dccp/ccids/ccid2.c net/dccp/ccids/ccid3.c+42 -4812 replies

Reviews trailers per patch

1 of 2 patches has a Reviewed-by or Acked-by.

PatchIan McDonald
1/2A-b
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] [RFC]: Clean-ups

Quoting Arnaldo Carvalho de Melo:

|  most things merged, except for the packet size and
|  TRFC equation patches, that I thought a day or two would be nice for
|  further discussion.

I have tidied up what remained and uploaded the up-to-date remaining patches on to
http://www.erg.abdn.ac.uk/users/gerrit/dccp/patch-backlog/

There are two small patches which I send as RFC, for the first I need a consensus:

Patch 1: Removes a typo in setting the nofeedback timer.
=> Question: The nofeedback timer is currently set to time out after

max(t_rto, 2 * s/X) = max(max(4*R, 1 second), 2 *s/X)

This is non-standard and has been flagged in the code as such
I have conferred with a colleague who does a lot of simulations in this field and he says doing this is bad, especially when the RTTs are small. Therefore, since it is both non-standard and obviously not a good idea, I want to suggest revising the entire patch so that the nofeedback timer expires after max(4*R, 2 * s/X) as per RFC 3448.
OK with this suggestion?

Patch 2: Implements a useful idea which Ian suggested while discussing one of the
previous patches: if the len' arguments of ccid_{send_packet,packet_sent}() are unsigned, then we do not need to perform extra checks against len > 0' The patch implements this idea and, as a result, another unused block/test in ccid3.c can go.

Gerrit