Skip to content

chelsio: lightweight review

Francois Romieu netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 2 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7chelsio: move return, break and continue statements on their own linedrivers/net/chelsio/espi.c drivers/net/chelsio/ixf1010.c drivers/net/chelsio/mv88e1xxx.c +3 more+20 -100 replies
2/7chelsio: the return statement is not a functiondrivers/net/chelsio/my3126.c drivers/net/chelsio/vsc7326.c+14 -140 replies
3/7chelsio: spaces, tabs and friendsdrivers/net/chelsio/common.h drivers/net/chelsio/cpl5_cmd.h drivers/net/chelsio/cxgb2.c +12 more+283 -2830 replies
4/7chelsio: use netdev_privdrivers/net/chelsio/cxgb2.c drivers/net/chelsio/sge.c+32 -322 replies
5/7chelsio: useless curly bracesdrivers/net/chelsio/cxgb2.c drivers/net/chelsio/mv88e1xxx.c drivers/net/chelsio/sge.c +1 more+8 -110 replies
6/7chelsio: useless test in cxgb2::remove_onedrivers/net/chelsio/cxgb2.c+16 -160 replies
7/7chelsio: misc cleanups in sgedrivers/net/chelsio/sge.c+19 -350 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] chelsio: lightweight review

The serie applies against netdev-2.6#upstream-linus or linux-2.6#master

Patches have been compiled. No further test.

It is available as:

git://electric-eye.fr.zoreil.com/home/romieu/linux-2.6.git#chelsio

Former 'chelsio' branch is archived as 'chelsio-20061206'.

Distance from 'master' (e62438630ca37539c8cc1553710bbfaa3cf960a7)
-----------------------------------------------------------------

c021b7a9f2dcb8867f513983c42049b46bc97999
e9c87a1d5674c56a33288177913b27911cefc7a3
b335493ac99e2a4c716e597d6a11108fc670db90
4cf12df7a8e19339038f4e7952abf85554733916
89e9d8ea4fbd032872e0a96b3f455b9de912b1f6
3c086dfee287469d5ee7b860eaec9be56b4ef0ef
9b59cb170afa01d1dd86383c5178b9c306dbd275

Diffstat
--------

 drivers/net/chelsio/common.h    |    2 
 drivers/net/chelsio/cpl5_cmd.h  |   18 ++--
 drivers/net/chelsio/cxgb2.c     |  161 ++++++++++++++++++-------------------
 drivers/net/chelsio/elmer0.h    |   40 +++++----
 drivers/net/chelsio/espi.c      |   44 +++++-----
 drivers/net/chelsio/fpga_defs.h |    6 +
 drivers/net/chelsio/gmac.h      |   11 ++
 drivers/net/chelsio/ixf1010.c   |   13 ++-
 drivers/net/chelsio/mv88e1xxx.c |   27 +++---
 drivers/net/chelsio/my3126.c    |   16 ++--
 drivers/net/chelsio/pm3393.c    |    8 +-
 drivers/net/chelsio/sge.c       |  172 ++++++++++++++++++---------------------
 drivers/net/chelsio/subr.c      |   89 ++++++++++----------
 drivers/net/chelsio/tp.c        |   62 +++++++-------
 drivers/net/chelsio/vsc7326.c   |   75 ++++++++---------
 drivers/net/chelsio/vsc8244.c   |   41 +++++----
 16 files changed, 388 insertions(+), 397 deletions(-)

Shortlog
--------

Francois Romieu:
chelsio: move return, break and continue statements on their own line
chelsio: the return statement is not a function
chelsio: spaces, tabs and friends
chelsio: use netdev_priv
chelsio: useless curly braces
chelsio: useless test in cxgb2::remove_one
chelsio: misc cleanups in sge

Patch
-----

See following messages.

Signature · 1 line
Ueimor