Skip to content

:

Gerrit Renker dccp 1 version In review

Get series with b4
b4 am 200612072112.10572@strip-the-willow

Versions newest first

  1. v1 Latest12 patches 16 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12: Simplify TFRC calculationnet/dccp/ccids/ccid3.h net/dccp/ccids/lib/tfrc.h net/dccp/ccids/lib/tfrc_equation.c+35 -351 reply
2/12: Only deliver to the CCID rx side in chargenet/dccp/ccids/ccid3.c net/dccp/input.c+19 -61 reply
3/12: Warn when discarding packet due to internal errorsnet/dccp/output.c+4 -21 reply
4/12: In-line ccid3_hc_tx_insert_optionsnet/dccp/ccids/ccid3.c+1 -71 reply
5/12: Initialise RTT valuesnet/dccp/ccids/ccid3.c+3 -11 reply
6/12: Sanity-check RTT samplesnet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h+12 -01 reply
7/12: Shift window counter computationnet/dccp/ccids/ccid3.c+29 -201 reply
8/12: TX history - remove unused fieldnet/dccp/ccids/ccid3.c+3 -21 reply
9/12: Perform history operations only after packet has been sentnet/dccp/ccids/ccid3.c+9 -291 reply
10/12: Make debug output consistentnet/dccp/ccids/ccid3.c+29 -321 reply
11/12: Reorder packet history header filenet/dccp/ccids/lib/packet_history.h+68 -601 reply
12/12: Reorder packet history source filenet/dccp/ccids/lib/packet_history.c+112 -1070 replies

Reviews trailers per patch

9 of 12 patches have a Reviewed-by or Acked-by.

PatchIan McDonald
1/12A-b
2/12A-b
3/12A-b
4/12
5/12A-b
6/12A-b
7/12A-b
8/12
9/12A-b
10/12A-b
11/12A-b
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [Patch 0/12]:

Here is the latest batch of updates for CCID3. I held it back for almost two days, got bogged down by testing.

As an experiment (not part of the patch set), I tried to set the tx timestamp not in ccid3_hc_tx_packet_sent but in ccid3_hc_tx_send_packet. The result was that on SMP computers I got several bug messages that "r_sample < 0" (in ccid3_hc_tx_packet_recv).

This is a hint that the mysteriously high RTT values have to do with the way the history is updated.

I am almost fully convinced that it is necessary to armour the packet history list operations with read/write locks. The reasons:

* list manipulation is asynchronous, packet_sent/send_packet fill the list, while packet_recv purges

* send_packet may sleep so that meanwhile new entries are put on top

* after applying patch 9 I got, for the first time, accurate RTT values [patch 9 puts all history work into packet_sent]

It would be good to have further opinions/ideas on this.

Here is now the overview:

Patch 1: completes the migration towards using scaled_div/scaled_div32, by
updating the TFRC calculation also.

Patch 2: attempts to reduce CPU load by only delivering to the CCID module
which is currently active, to avoid unnecessary processing.

Patch 3: warns when discarding a TX packet; also, EINTR is no longer a bug case.

Patch 4: reduces ccid3_hc_tx_insert_options, since currently all its operations are
redundant.

Patch 5: takes care that the RTT values are all initialised properly.

Patch 6: sanity-checks RTT values. Thanks Ian :-)

Patch 7: puts all window counter updating functionality into an extra routine.

Patch 8: Removes the unused dccphtx_ccval field - it is used nowhere and not needed.
=> Note: The same holds for the u32 field `dccphtx_rtt' - it is
also not needed by the code. Shall it also be removed ???

Patch 9: concentrates all history updating in packet_sent. I believe that this is
much cleaner and could already observe much shorter RTT values than usual.

Patch 10: clerical - unifies the output format of debugging messages (less confusing).

Patch 11: clerical - I had difficulties reading packet_history.h since rx/tx function
declarations are intermingled. This just reorders them to appear separate and following the same order of declarations.

Patch 12: clerical - does the same as patch 11, but for the source file.