Skip to content

PM: Change ordering of suspend and resume code

Rafael J. Wysocki lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4PM: Change code ordering in main.ckernel/power/main.c+19 -150 replies
2/4swsusp: Change code ordering in disk.ckernel/cpu.c kernel/power/disk.c+57 -550 replies
3/4swsusp: Change code ordering in user.ckernel/power/user.c+58 -340 replies
4/4swsusp: Change pm_ops handling by userland interfacekernel/power/user.c+51 -130 replies

Reviews trailers per patch

All 4 patches have a Reviewed-by or Acked-by.

PatchPavel Machek
1/4A-b
2/4A-b
3/4A-b
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -mm 0/4] PM: Change ordering of suspend and resume code

Hi,

As indicated in a recent thread on Linux-PM, it's necessary to call pm_ops->finish() before devce_resume(), but enable_nonboot_cpus() has to be called before pm_ops->finish()
(cf. http://lists.osdl.org/pipermail/linux-pm/2006-November/004164.html).
For consistency, it seems reasonable to call disable_nonboot_cpus() after device_suspend().

This way the suspend code will remain symmetrical with respect to the resume code and it may allow us to speed up things in the future by suspending and resuming devices and/or saving the suspend image in many threads.

The following series of patches reorders the suspend and resume code so that nonboot CPUs are disabled after devices have been suspended and enabled before the devices are resumed.  It also causes pm_ops->finish() to be called after enable_nonboot_cpus() wherever necessary.

Greetings,
Rafael

Signature · 3 lines
If you don't have the time to read,
you don't have the time or the tools to write.
		- Stephen King