Skip to content

RFC a faster buffered write deadlock fix?

Nick Piggin linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest3 patches 30 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3fs: add an iovec iteratorinclude/linux/fs.h mm/filemap.c mm/filemap.h+137 -1307 replies
2/3fs: introduce perform_write aopinclude/linux/fs.h mm/filemap.c+47 -238 replies
3/3ext2: use perform_write aopfs/buffer.c fs/ext2/inode.c include/linux/buffer_head.h +1 more+153 -05 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [rfc][patch 0/3] a faster buffered write deadlock fix?

In my last set of numbers for my buffered-write deadlock fix using 2 copies per page, I realised there is no real performance hit for !uptodate pages as opposed to uptodate ones. This is unexpected because the uptodate pages only require a single copy...

The problem turns out to be operator error. I forgot tmpfs won't use this prepare_write path, so sorry about that.

On ext2, copy 64MB of data from /dev/zero (IO isn't involved), using 4K and 64K block sizes, and conv=notrunc for testing overwriting of uptodate pages. Numbers is elapsed time in seconds, lower is better.

		2.6.20		bufferd write fix

4K 0.0742 0.1208 (1.63x)
4K-uptodate 0.0493 0.0479 (0.97x)
64K 0.0671 0.1068 (1.59x)
64K-uptodate 0.0357 0.0362 (1.01x)

So we get about a 60% performance hit, which is more expected. I guess if 0.5% doesn't fly, then 60% is right out ;)

If there were any misconceptions, the problem is not that the code is incredibly tricky or impossible to fix with good performance. The problem is that the existing aops interface is crap. "correct, fast, compatible -- choose any 2"

So I have finally finished a first slightly-working draft of my new aops op (perform_write) proposal. I would be interested to hear comments about it. Most of my issues and concerns are in the patch headers themselves, so reply to them.

The patches are against my latest buffered-write-fix patchset. This means filesystems not implementing the new aop, will remain safe, if slow. Here's some numbers after converting ext2 to the new aop:

		2.6.20		perform_write aop

4K 0.0742 0.0769 (1.04x)
4K-uptodate 0.0493 0.0475 (0.96x)
64K 0.0671 0.0613 (0.91x)
64K-uptodate 0.0357 0.0343 (0.96x)

Thanks,
Nick

--
SuSE Labs