Skip to content

RFC hugetlb: pagetable_operations API

Adam Litke linux-mm lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest7 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7Introduce the pagetable_operations and associated helper macros.include/linux/mm.h+25 -05 replies
2/7copy_vma for hugetlbfsfs/hugetlbfs/inode.c mm/memory.c+8 -20 replies
3/7pin_pages for hugetlbfs/hugetlbfs/inode.c mm/memory.c+4 -30 replies
4/7unmap_page_range for hugetlbfs/hugetlbfs/inode.c include/linux/hugetlb.h mm/hugetlb.c +1 more+16 -130 replies
5/7change_protection for hugetlbfs/hugetlbfs/inode.c mm/mprotect.c+4 -20 replies
6/7free_pgtable_range for hugetlbfs/hugetlbfs/inode.c mm/memory.c+4 -30 replies
7/7hugetlbfs fault handlerfs/hugetlbfs/inode.c mm/hugetlb.c mm/memory.c+6 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/7] [RFC] hugetlb: pagetable_operations API

The page tables for hugetlb mappings are handled differently than page tables for normal pages. Rather than integrating multiple page size support into the main VM (which would tremendously complicate the code) some hooks were created. This allows hugetlb special cases to be handled "out of line" by a separate interface.

Hugetlbfs was the huge page interface chosen. At the time, large database users were the only big users of huge pages and the hugetlbfs design meets their needs pretty well. Over time, hugetlbfs has been expanded to enable new uses of huge page memory with varied results. As features are added, the semantics become a permanent part of the Linux API. This makes maintenance of hugetlbfs an increasingly difficult task and inhibits the addition of features and functionality in support of ever-changing hardware.

To remedy the situation, I propose an API (currently called pagetable_operations). All of the current hugetlbfs-specific hooks are moved into an operations struct that is attached to VMAs. The end result is a more explicit and IMO a cleaner interface between hugetlbfs and the core VM. We are then free to add other hugetlb interfaces (such as a /dev/zero-styled character device) that can operate either in concert with or independent of hugetlbfs.

There should be no measurable performance impact for normal page users (we're checking if pagetable_ops != NULL instead of checking for vm_flags & VM_HUGETLB). Of course we do increase the VMA size by one pointer. For huge pages, there is an added indirection for pt_op() calls. This patch series does not change the logic of the the hugetlbfs operations, just moves them into the pagetable_operations struct.

Comments? Do you think it's as good of an idea as I do?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>