use symbolic constants in generic lseek code
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 1 replyIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | use symbolic constants in generic lseek codefs/ | +6 | 0 replies | |
| 2/2 | use use SEEK_MAX to validate user lseek argumentsfs/ include/ | +3 | 0 replies |
Reviews trailers per patch
None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.
| Patch | David Howells |
|---|---|
| Series | A-b |
| 1/2 | |
| 2/2 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/2] use symbolic constants in generic lseek code
The generic lseek code in fs/read_write.c uses hardcoded values for SEEK_{SET,CUR,END}.
Patch 1 fixes the case statements to use the symbolic constants in include/linux/fs.h, and should not be at all controversial.
Patch 2 adds a SEEK_MAX and uses it to validate user arguments. This makes the code a little cleaner and also enables future extensions (such as SEEK_DATA and SEEK_HOLE). If anyone has a problem with this, please speak up.
-- Chris