RFC swsusp: Do not use page flags (was: Re: Remove page flags for software suspend)
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest3 patches 26 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | swsusp: Do not use page flags directlyinclude/ kernel/ mm/ | +61 | 1 reply | |
| 2/3 | swsusp: Do not use page flagsarch/ include/ kernel/ +3 more | +281 | 8 replies | |
| 3/3 | mm: Remove nosave and nosave_free page flagsinclude/ | +0 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC][PATCH 0/3] swsusp: Do not use page flags (was: Re: Remove page flags for software suspend)
Quoted 32 lines · Rafael J. Wysocki
Quoted 22 lines · Nick Piggin
Quoted 8 lines · Rafael J. Wysocki
Quoted 6 lines · Christoph Lameter
Quoted 2 lines · Pavel Machek
I... actually do not like that patch. It adds code... at little or no benefit.
Quoted 8 lines
Quoted 3 lines
We are looking into saving page flags since we are running out. The two page flags used by software suspend are rarely needed and should be taken out of the flags. If you can do it a different way then please do.
As I have already said for a couple of times, I think we can and I'm going to do it, but right now I'm a bit busy with other things that I consider as more urgent.
I need one bit for lockless pagecache ;)
Anyway, I guess if you want something done you have to do it yourself.
Quoted 8 lines
This patch still needs work (and I don't know if it even works, because I can't make swsusp resume even on a vanilla kernel). But this is my WIP for removing swsusp page flags.
This patch adds a simple extent based nosave region tracker, and rearranges some of the snapshot code to be a bit simpler and more amenable to having dynamically allocated flags (they aren't actually dynamically allocated in this patch, however).
Quoted 7 lines
Thanks for the patch.
Probably I'd like to do some things in a different way, I'll think about that later today.
I hope I'll have a working patch that removes the "offending" page flags after the weekend.
Okay, the next three messages contain patches that should do the trick.
They have been tested on x86_64, but not very thoroughly.
Greetings,
Rafael
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>