Skip to content

: Netfilter fixes

Patrick McHardy netfilter-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10: conntrack: fix {nf, ip}_ct_iterate_cleanup endless loopsinclude/linux/netfilter_ipv4/ip_conntrack_core.h include/net/netfilter/nf_conntrack_core.h net/ipv4/netfilter/ip_conntrack_core.c +1 more+4 -40 replies
2/10: nf_conntrack/nf_nat: fix incorrect config ifdefsnet/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c net/ipv4/netfilter/nf_conntrack_proto_icmp.c net/ipv4/netfilter/nf_nat_core.c +10 more+20 -400 replies
3/10: tcp conntrack: accept SYN|URG as validnet/ipv4/netfilter/ip_conntrack_proto_tcp.c net/netfilter/nf_conntrack_proto_tcp.c+6 -20 replies
4/10: nfnetlink_log: fix reference leaknet/netfilter/nfnetlink_log.c+4 -30 replies
5/10: nfnetlink_log: fix use after freenet/netfilter/nfnetlink_log.c+1 -10 replies
6/10: nfnetlink_log: fix NULL pointer dereferencenet/netfilter/nfnetlink_log.c+1 -00 replies
7/10: nfnetlink_log: fix possible NULL pointer dereferencenet/netfilter/nfnetlink_log.c+4 -00 replies
8/10: nfnetlink_log: fix module reference countingnet/netfilter/nfnetlink_log.c+1 -20 replies
9/10: nfnetlink_log: fix reference countingnet/netfilter/nfnetlink_log.c+6 -30 replies
10/10: ip6_route_me_harder should take into account marknet/ipv6/netfilter.c+1 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [NETFILTER 00/10]: Netfilter fixes

Hi Dave,

following are a number of netfilter fixes for 2.6.21, fixing an endless loop during module unload with conntrack events enabled, multiple problems with nfnetlink_log, incorrect ctnetlink config ifdefs in nf_conntrack and nf_nat and missing mark initialization in ip6_route_me_harder. Most of them should also go in -stable, I'll send backports soon.

Please apply, thanks.

 include/linux/netfilter_ipv4/ip_conntrack_core.h |    2 -
 include/net/netfilter/nf_conntrack_core.h        |    2 -
 net/ipv4/netfilter/ip_conntrack_core.c           |    2 -
 net/ipv4/netfilter/ip_conntrack_proto_tcp.c      |    4 ++-
 net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c   |    6 +----
 net/ipv4/netfilter/nf_conntrack_proto_icmp.c     |    6 +----
 net/ipv4/netfilter/nf_nat_core.c                 |    3 --
 net/ipv4/netfilter/nf_nat_proto_gre.c            |    3 --
 net/ipv4/netfilter/nf_nat_proto_icmp.c           |    3 --
 net/ipv4/netfilter/nf_nat_proto_tcp.c            |    3 --
 net/ipv4/netfilter/nf_nat_proto_udp.c            |    3 --
 net/ipv6/netfilter.c                             |    1 
 net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c   |    6 +----
 net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c   |    6 +----
 net/netfilter/nf_conntrack_core.c                |    5 +---
 net/netfilter/nf_conntrack_proto_gre.c           |    3 --
 net/netfilter/nf_conntrack_proto_tcp.c           |   13 +++++------
 net/netfilter/nf_conntrack_proto_udp.c           |    6 +----
 net/netfilter/nfnetlink_log.c                    |   26 +++++++++++++++--------
 19 files changed, 48 insertions(+), 55 deletions(-)

Michal Miroslaw:
[NETFILTER]: nfnetlink_log: fix reference leak [NETFILTER]: nfnetlink_log: fix use after free [NETFILTER]: nfnetlink_log: fix NULL pointer dereference [NETFILTER]: nfnetlink_log: fix possible NULL pointer dereference [NETFILTER]: nfnetlink_log: fix reference counting

Patrick McHardy:
[NETFILTER]: conntrack: fix {nf,ip}_ct_iterate_cleanup endless loops [NETFILTER]: nf_conntrack/nf_nat: fix incorrect config ifdefs [NETFILTER]: tcp conntrack: accept SYN|URG as valid [NETFILTER]: nfnetlink_log: fix module reference counting

Yasuyuki Kozakai:
[NETFILTER]: ip6_route_me_harder should take into account mark