Skip to content

misc. cleanups

Shawn O. Pearce git 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9Display the null SHA-1 as the base for an OBJ_OFS_DELTA.sha1_file.c+1 -00 replies
2/9Fix mmap leak caused by reading bad indexes.sha1_file.c+16 -90 replies
3/9Don't build external_grep if its not usedbuiltin-grep.c+2 -00 replies
4/9General const correctness fixesbuiltin-blame.c builtin-branch.c builtin-for-each-ref.c +13 more+40 -420 replies
5/9Use uint32_t for all packed object counts.builtin-fsck.c cache.h pack-check.c +2 more+15 -150 replies
6/9Use uint32_t for pack-objects counters.builtin-pack-objects.c+30 -333 replies
7/9Use off_t when we really mean a file offset.cache.h fast-import.c git-compat-util.h +3 more+54 -470 replies
8/9Use off_t in pack-objects/fast-import when we mean an offsetbuiltin-pack-objects.c fast-import.c+28 -280 replies
9/9Cast 64 bit off_t to 32 bit size_tbuiltin-apply.c builtin-blame.c builtin-count-objects.c +13 more+83 -590 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] misc. cleanups

This is a series of various cleanups that I have pending at the front of my pack v4 topic. The earlier ones are annoying nits, the later ones fix compiler errors caused by compiling with:

--snip--
CFLAGS += -Wall -ansi -pedantic -std=c99

ifdef strict

          CFLAGS += -Werror
          CFLAGS += -Wfour-char-constants
          CFLAGS += -fnon-lvalue-assign
          CFLAGS += -Wdeclaration-after-statement
          CFLAGS += -Wpointer-arith
          CFLAGS += -Wbad-function-cast
          CFLAGS += -Wcast-align
          CFLAGS += -Wwrite-strings
          CFLAGS += -Wshorten-64-to-32
  
          # No, currently a huge set.
          #CFLAGS += -Wsign-compare
  
          # No, only in diffcore-rename and that's ok.
          #CFLAGS += -Wfloat-equal
  
          # No, unused parameters, -Wsign-compare, missing initializers.
          # CFLAGS += -Wextra
  
          # No, memcmp trips on signed/unsigned conversion.
          # CFLAGS += -Wconversion

endif
--snap--

Signature · 1 line
Shawn.