Skip to content

: pkt_sched.h cleanup + misc changes

Patrick McHardy netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest11 patches 5 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11: sch_netem: fix off-by-one in send time comparisonnet/sched/sch_netem.c+1 -11 reply
2/11: kill PSCHED_AUDIT_TDIFFinclude/net/pkt_sched.h net/sched/sch_cbq.c+0 -30 replies
3/11: kill PSCHED_TADD/PSCHED_TADD2include/net/pkt_sched.h net/sched/sch_cbq.c net/sched/sch_netem.c+7 -90 replies
4/11: kill PSCHED_TLESSinclude/net/pkt_sched.h net/sched/sch_cbq.c net/sched/sch_netem.c+6 -80 replies
5/11: kill PSCHED_SET_PASTPERFECT/PSCHED_IS_PASTPERFECTinclude/net/pkt_sched.h include/net/red.h net/sched/sch_cbq.c +1 more+12 -140 replies
6/11: kill PSCHED_TDIFFinclude/net/pkt_sched.h net/sched/sch_cbq.c+7 -80 replies
7/11: turn PSCHED_TDIFF_SAFE into inline functioninclude/net/pkt_sched.h include/net/red.h net/sched/act_police.c +2 more+14 -100 replies
8/11: turn PSCHED_GET_TIME into inline functioninclude/net/pkt_sched.h include/net/red.h net/sched/act_police.c +5 more+29 -330 replies
9/11: Unline tcf_destroyinclude/net/sch_generic.h net/sched/sch_api.c net/sched/sch_atm.c +6 more+30 -780 replies
10/11: qdisc: remove unnecessary memory barriersnet/sched/sch_api.c+0 -20 replies
11/11: qdisc: avoid dequeue while throttlednet/sched/sch_generic.c net/sched/sch_netem.c+4 -43 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [NET_SCHED 00/11]: pkt_sched.h cleanup + misc changes

These patches fix an off-by-one in netem, clean up pkt_sched.h by removing most of the now unnecessary PSCHED time macros and turning the two remaining ones into inline functions, consolidate some common filter destruction code and move the TCQ_F_THROTTLED optimization from netem to qdisc_restart.

Please apply, thanks.

 include/net/pkt_sched.h   |   24 +++++++-------
 include/net/red.h         |   10 +++---
 include/net/sch_generic.h |   10 +-----
 net/sched/act_police.c    |   17 ++++------
 net/sched/sch_api.c       |   20 ++++++++++--
 net/sched/sch_atm.c       |   17 +---------
 net/sched/sch_cbq.c       |   76 ++++++++++++++++++----------------------------
 net/sched/sch_dsmark.c    |    8 ----
 net/sched/sch_generic.c   |    4 ++
 net/sched/sch_hfsc.c      |   23 +++----------
 net/sched/sch_htb.c       |   24 ++++----------
 net/sched/sch_ingress.c   |    7 ----
 net/sched/sch_netem.c     |   24 +++++---------
 net/sched/sch_prio.c      |    7 ----
 net/sched/sch_tbf.c       |    9 ++---
 15 files changed, 110 insertions(+), 170 deletions(-)

Patrick McHardy (11):
[NET_SCHED]: sch_netem: fix off-by-one in send time comparison [NET_SCHED]: kill PSCHED_AUDIT_TDIFF
[NET_SCHED]: kill PSCHED_TADD/PSCHED_TADD2 [NET_SCHED]: kill PSCHED_TLESS
[NET_SCHED]: kill PSCHED_SET_PASTPERFECT/PSCHED_IS_PASTPERFECT [NET_SCHED]: kill PSCHED_TDIFF
[NET_SCHED]: turn PSCHED_TDIFF_SAFE into inline function [NET_SCHED]: turn PSCHED_GET_TIME into inline function [NET_SCHED]: Unline tcf_destroy
[NET_SCHED]: qdisc: remove unnecessary memory barriers [NET_SCHED]: qdisc: avoid dequeue while throttled