Skip to content

NLM - lock failover

J. Bruce Fields cluster-devel linux-nfs 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 4 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 4 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [NFS] [Cluster-devel] [PATCH 0/4 Revised] NLM - lock failover
Quoted 7 lines · Wendy Cheng
Quoted 6 lines · J. Bruce Fields
Quoted 3 lines · Christoph Hellwig

In fact couldn't this be treated as a reexport with a NFSEXP_ flag meaning drop all locks to avoid creating new interfaces?

Quoted 6 lines
Quoted 4 lines

Off hand, I can't see any reason why that wouldn't work. The code to handle it would probably go in fs/nfsd/export.c:svc_export_parse().

Sign :( ... folks, we go back to the loop again. That *was* my first proposal ...

So you're talking about this and followups?:

	http://marc.info/?l=linux-nfs&m=115009204513790&w=2

I just took a look and couldn't find any complaints about that approach. Were they elsewhere?

I understand the frustration. There's a balance betweeen on the one hand, being willing to throw out some hard work and start over if someone comes up with a real objection, and, on the other hand, sticking to a design when you're convinced it's right.

I *really* appreciate good review, but I also try to avoid doing something I don't like just because it seems to be the only way to make somebody else happy.... If they've got a real point then I should be able to understand it. If not, then I risk doing all the work to make them happy just to throw it away because I can't defend the approach in the end, or because I find out I misunderstood their original point.

(Then again, sometimes I do just have to trust somebody. And sometimes I guess learning who can be trusted about what is part of the process.)

In this case I think the complaint about requiring fsid's on everything is legimate, and the original approach of using the export was sensible. But I haven't been paying as much attention as I should have, and I probably missed something.

--b.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs