NLM - lock failover
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest0 of 4 patches 0 repliesNew
Patches in v1 No applies recorded yet
None of the 4 patches the cover letter announces are in this archive.
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [NFS] [Cluster-devel] [PATCH 0/4 Revised] NLM - lock failover
Quoted 7 lines · Neil Brown
A flag to unexport cannot work because we don't call unexport - we just flush a kernel cache.
A flag to export is just .... weird. All the other export flags are state flags. This would be an action flag. They are quite different
things. Setting a state flag again is a no-op. Setting an action
flag again has a very real effect.
In this case the second set shouldn't have any effect--whatever flag is set should prevent further locks from being accepted, shouldn't it? (If it matters.)
Quoted 5 lines
Also, each filesystem is potentially exported multiple times for different sets of clients. If such a flag (whether on 'export' or 'unexport') just said "remove locks from this set of clients" it wouldn't meet the needs, and if it said "remove all locks" it would be a very irregular interface.
The same could be said of the "fsid=" option on exports. It doesn't make sense to provide different filehandle- or path- name spaces depending on the IP address of a client. If my laptop changes IP address, then I can (grudgingly) accept the fact that the server may have to deny me access that I had before--maybe it just can't trust the network I moved to for whatever reason--but I'd really rather it didn't suddenly start giving me paths, or different filehandles, or different semantics (like sync vs. async).
So the export interface is already being used for stuff that's really intended to be per-filesystem rather than per-(filesystem, client) pair.
Quoted 10 lines
Quoted 6 lines
So you're talking about this and followups?:
http://marc.info/?l=linux-nfs&m=115009204513790&w=2I just took a look and couldn't find any complaints about that approach. Were they elsewhere?
https://www.redhat.com/archives/linux-cluster/2006-June/msg00101.html
Is where I said that I don't like the unexport flag.
Got it, thanks.
--b.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - [email protected]
https://lists.sourceforge.net/lists/listinfo/nfs