Skip to content

genhomedircon replacement in libsemanage

[email protected] selinux 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 58 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3libsemanage: genhomedircon replacementlibselinux/src/file_path_suffixes.h libsemanage/src/genhomedircon.c libsemanage/src/genhomedircon.h +3 more+1172 -1454 replies
2/3libsemanage: test functionslibsemanage/tests/libsemanage-tests.c libsemanage/tests/test_utilities.c libsemanage/tests/test_utilities.h+304 -00 replies
3/3Remove legacy genhomedircon python scriptpolicycoreutils/scripts/Makefile policycoreutils/scripts/genhomedircon policycoreutils/scripts/genhomedircon.8+1 -4730 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/3] genhomedircon replacement in libsemanage

This replaces genhomedircon with equivalent functionality in libsemanage. The homedir_template is also no longer installed, this leaves some unused path functions in libselinux but removing those would break the ABI.

This does the same things that genhomedircon did though some seemed strange, like removing /sbin/nologin from the list of valid shells, presumably to keep ftp users and such from getting file contexts generated for them, I'm not sure how valid the assumption is but we didn't want to change the functionality of genhomedircon in this patch set.

The first patch adds genhomedircon.c to libsemanage and calls it from the semanage_store.c and removes the prior call to genhomedircon.

The second patch is a set of tests for the new functions

And the third patch removes the old genhomedircon script.

Signature · 4 lines
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to [email protected] with
the words "unsubscribe selinux" without quotes as the message.