swsusp: Fix hibernation/restore code ordering
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest4 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | swsusp: Remove incorrect code from user.ckernel/ | +4 | 0 replies | |
| 2/4 | swsusp: Remove code duplication between disk.c and user.ckernel/ kernel/ kernel/ | +115 | 0 replies | |
| 3/4 | swsusp: Introduce restore platform operationsdrivers/ include/ kernel/ +3 more | +92 | 0 replies | |
| 4/4 | swsusp: Fix hibernation code orderingkernel/ | +7 | 0 replies |
Reviews trailers per patch
3 of 4 patches have a Reviewed-by or Acked-by.
| Patch | Pavel Machek |
|---|---|
| 1/4 | A-b |
| 2/4 | A-b |
| 3/4 | |
| 4/4 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH -mm 0/4] swsusp: Fix hibernation/restore code ordering
Hi,
In the face of the recent change of suspend code ordering (cf. http://marc.info/?l=linux-acpi&m=117938245931603&w=2) we should also modify the code ordering in swsusp so that hibernation_ops->prepare() is executed after device_suspend().
However, for this purpose it seems reasonable to eliminate the code duplication between kernel/power/disk.c and kernel/power/user.c first. By eliminating it we can reduce the size of user.c quite substantially and remove the maintenance difficulty with making essentially the same changes in two different places.
Moreover, we should also remove the calls to "platform" functions from the restore code path, since it doesn't carry out any power transition of the system, but we generally need to disable the GPEs before the restore if the 'platform' hibernation mode has been used. To do this, we can introduce two new hibernation_ops to be used in the restore code.
Greetings,
Rafael