Skip to content

: Misc CCID3 patches | TFRC separate module | end of first half

Gerrit Renker dccp 1 version In review

Get series with b4
b4 am 200706141004.34231@strip-the-willow

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5: Receiver does not set CCValnet/dccp/ccids/ccid3.c+0 -21 reply
2/5: History access is redundant when sending feedbacknet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h net/dccp/ccids/lib/packet_history.c +1 more+31 -582 replies
3/5: Move NULL-protection into functionnet/dccp/ccids/ccid3.c net/dccp/ccids/ccid3.h+12 -261 reply
4/5: Wait for CCIDnet/dccp/output.c+19 -151 reply
5/5: Provide central source file and debug facilitynet/dccp/ccids/Kconfig net/dccp/ccids/lib/Makefile net/dccp/ccids/lib/packet_history.c +3 more+50 -142 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5]: Misc CCID3 patches | TFRC separate module | end of first half

This patch bundle completes the `first round' of the patch set.

I have put in some work to make it compileable - there is just one patch interdepence with regard to line 961 - the receiver RTT sampling, which is part of the second half of the patch set.

However, for best results I do recommend applying all patches.

Patch submission will continue with the second half tomorrow; this has 21 patches, so that the `end' can be expected by mid next week.

Comments will be addressed, and if there are no major disagreements, I'd suggest to place the set into the test tree and make it available for pulling - in that way the changes are much easier to see.

Patch #1: CCID3 receiver does not set CCVal - fixed hereby.

Patch #2: Avoids double access of TX history when sending CCID3 feedback,
removes an unused state and redundant variables in send_feedback(), and converts it to use the newer ktime_t interface.
=> This resolves one more dependency in the upgrade to ktime_t.

Patch #3: Gathers repeated use of test-for-NULL statement into function call.

Patch #4: Update for the wait_for_ccid code (small optimisation)

Patch #5: Creates a central module source file, dccp/ccids/lib/tfrc_module.c,
as a main file for dccp_tfrc_lib. Previously the module has been assembled from packet_history.c, loss_interval.c, and tfrc_equation.c. Since each of these source files serves a distinct purpose, it was not clear where module initialisation, cleanup, and module parameters are to be stored - done now in this file. Plus a separate tfrc debug macro.