Skip to content

AppArmor - Don't pass NULL nameidata to vfs_create/lookup/permission IOPs

[email protected] linux-fsdevel lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Pass no useless nameidata to the create, lookup, and permission IOPsfs/9p/vfs_inode.c fs/adfs/dir.c fs/affs/affs.h +108 more+282 -2634 replies
2/4Never pass a NULL nameidata to vfs_create()fs/namei.c fs/nfsd/vfs.c ipc/mqueue.c+32 -190 replies
3/4Dont use a NULL nameidata in xattr_permission()fs/xattr.c+13 -50 replies
4/4Pass nameidata2 to permission() from nfsd_permission()fs/nfsd/vfs.c+7 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFD 0/4] AppArmor - Don't pass NULL nameidata to vfs_create/lookup/permission IOPs
Signature · 26 lines
This post is a request for discussion on creating a second smaller
nameidata struct to eliminate conditionally passing of vfsmounts
to the LSM.

It contains a series of patches that apply on top of the AppArmor
patch series.  These patches were previously post on May 14,
but received no feedback.  Any and all feedback is welcome so
that we can improve these patches or replace them with a better
solution if one presents it self.

To remove conditionally passing of vfsmounts to the LSM, a nameidata
struct can be instantiated in the nfsd and mqueue filesystems.  This
however results in useless information being passed down, as not
all fields in the nameidata struct will be meaingful.  The nameidata
struct is split creating struct nameidata2 that contains only the fields
that will carry meaningful information.

The creation of the nameidata2 struct raises the possibility of
replacing the current dentry, vfsmount argument pairs in the
vfs and lsm patches with a single nameidata2 argument although these
patches do not currently do this.

A tarball of these patches and the AppArmor kernel patches  are
available at:

  http://forgeftp.novell.com//apparmor/LKML_Submission-June-07/