omap2 clock: framework generalization, cleanup
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest25 of 28 patches 15 repliesIn review
25 of 28 patches are in this archive. The cover letter announces 28.
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/28 | omap2 clock: dsp_ick parent is dsp_fck, not core_ckarch/ | +1 | 0 replies | |
| 2/28 | omap2 clock: generalize initial clock rate setup: recalculate_root_clocks()arch/ arch/ arch/ +1 more | +23 | 0 replies | |
| 3/28 | omap2 clock: mark onchip_clks as __initdataarch/ | +1 | 0 replies | |
| 5/28 | omap2 clock: rename, add comment to omap2_mpu_recalc()arch/ arch/ | +9 | 0 replies | |
| 6/28 | omap2 clock: add clksel and clksel_rate dataarch/ arch/ include/ | +557 | 0 replies | |
| 7/28 | omap2 clock: init clksel clock parents to hardware reality at clock initarch/ arch/ | +75 | 2 replies | |
| 8/28 | omap2 clock: convert omap2_clksel_to_divisor and omap2_divisor_to_clksel to use new clksel structarch/ arch/ | +102 | 0 replies | |
| 9/28 | omap2 clock: convert omap2_clksel_round_rate to use new clksel structarch/ | +50 | 0 replies | |
| 10/28 | omap2 clock: convert omap2_get_clksel to use new clksel structarch/ | +13 | 0 replies | |
| 11/28 | omap2 clock: convert omap2_clksel_get_src_field() to use new clksel structarch/ | +25 | 0 replies | |
| 12/28 | omap2 clock: stop using clk->src_offset in omap2_clk_set_rate()arch/ | +3 | 0 replies | |
| 13/28 | omap2 clock: stop using clk->src_offset in omap2_clk_set_parent()arch/ | +4 | 0 replies | |
| 14/28 | omap2 clock: clean out old code from omap2_clksel_recalc()arch/ | +8 | 0 replies | |
| 15/28 | omap2 clock: convert remaining clksel clocks to use omap2_clksel_recalcarch/ | +27 | 0 replies | |
| 16/28 | omap2 clock: remove all {src, rate}_offset fields from struct clkarch/ arch/ include/ | +6 | 0 replies | |
| 17/28 | omap2 clock: use the struct clk round_rate field for clksel rate rounding codearch/ arch/ | +51 | 0 replies | |
| 19/28 | omap2 clock: drop RATE_CKCTL from all OMAP2 clocksarch/ | +21 | 0 replies | |
| 20/28 | omap2 clock: remove *_SEL* clock flagsarch/ arch/ include/ | +41 | 0 replies | |
| 21/28 | omap2 clock: call clock-specific enable/disable functions if presentarch/ | +8 | 0 replies | |
| 22/28 | omap2 clock: use custom osc_ck enable/disable routinesarch/ arch/ | +19 | 0 replies | |
| 23/28 | omap2 clock: use standard clk->enable/disable for APLLsarch/ arch/ | +14 | 0 replies | |
| 24/28 | omap2 clock: replace omap2_get_crystal_rate() with clock-specific recalc codearch/ arch/ | +29 | 0 replies | |
| 25/28 | omap2 clock: Standardize DPLL rate recalculation with struct dpll_dataarch/ arch/ include/ | +61 | 0 replies | |
| 27/28 | omap2 clock: add three missing clocks: gpmc_fck, sdma_{i, f}ckarch/ | +24 | 0 replies | |
| 28/28 | omap2 clock: handle (almost) all clock autoidling via the clock frameworkarch/ arch/ arch/ +3 more | +204 | 13 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 00/28] omap2 clock: framework generalization, cleanup
Hello,
This set of patches contains some significant changes to the OMAP2 clock framework. The main goal of these patches is to generalize the framework enough to be usable for the OMAP3430 clock tree, although in the process I think the OMAP2 clock code is improved quite a bit - I hope you'll agree.
The major change in this patch set is the rewrite of clksel clock handling, which:
* enables clksel parent clocks to be updated at clock framework init, from whatever the bootloader configured,
* properly encodes platform restrictions for particular rates,
* generalizes the clksel code to be useful for OMAP3430 clocks,
* facilitates future improved clock state reporting,
* and improves readability and maintainability.
The clksel patches are patches 6 through 20. A few other notable changes in this patchset:
* Cleanups/bug fixes: patches 1, 3, 4, 5
* Generalize root clock propagation at clock framework init: patch 2
* Use OMAP clock framework enable/disable fns for osc_ck, APLLs: patches 21, 22, 23
* Recalculate osc_ck and sys_ck via recalculate fns, rather than omap2_get_crystal_rate(): patch 24
* Generalize DPLL multiplier, divider handling: patches 25
* Generalize clocks enabled at init via ENABLE_ON_INIT clock flag: patch 26
* Generalize clock autoidle configuration: patches 27, 28
The patches were boot-tested on N800. Comments and testing are appreciated. In particular, any testing on 2430SDP are particularly welcome, since I don't have one here.
Patches apply cleanly against current git head, and seem to run fine, but I've been doing most of my testing against 2.6.22-omap1, since my N800 touchscreen does not work consistently with git head.
These changes increase uncompressed kernel memory footprint by about 6kB:
text data bss dec hex filename
2877920 147788 85992 3111700 2f7b14 vmlinux.orig 2881092 150908 85992 3117992 2f93a8 vmlinux
diffstat:
arch/arm/mach-omap2/clock.c | 978 +++++++++---------- arch/arm/mach-omap2/clock.h | 1092 +++++++++++++++++----- arch/arm/plat-omap/clock.c | 20 include/asm-arm/arch-omap/clock.h | 57 - linux-omap/arch/arm/mach-omap2/board-n800-audio.c | 13 linux-omap/arch/arm/mach-omap2/clock.c | 6 linux-omap/arch/arm/mach-omap2/clock.h | 2 linux-omap/arch/arm/mach-omap2/cm_regbits_24xx.h | 50 + linux-omap/arch/arm/mach-omap2/pm.c | 63 - linux-omap/arch/arm/plat-omap/clock.c | 17 linux-omap/include/asm-arm/arch-omap/clock.h | 1 11 files changed, 1492 insertions(+), 807 deletions(-)
My apologies in advance for the double 'Index:' lines in some of the patches - must be some quilt bug - it seems harmless and I have not yet had the chance to track it down.
- Paul