Skip to content

vnode/vfs and vnode/vfs operations removal

Christoph Hellwig linux-xfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest16 of 17 patches 12 repliesIn review

16 of 17 patches are in this archive. The cover letter announces 17.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17decontaminate vnode operations from behavior detailsfs/xfs/Makefile-linux-2.6 fs/xfs/dmapi/xfs_dm.c fs/xfs/linux-2.6/xfs_fs_subr.c +19 more+777 -4940 replies
2/17call common xfs vnode-level helpers directly and remove vnode operationsfs/xfs/Makefile-linux-2.6 fs/xfs/dmapi/xfs_dm.c fs/xfs/dmapi/xfs_dm_bhv.c +29 more+224 -9130 replies
3/17kill v_vfsp member from struct bhv_vnodefs/xfs/dmapi/xfs_dm.c fs/xfs/dmapi/xfs_dm_fsops.c fs/xfs/linux-2.6/xfs_file.c +9 more+50 -530 replies
4/17kill the v_flag member in struct bhv_vnodefs/xfs/dmapi/xfs_dm.c fs/xfs/linux-2.6/xfs_aops.c fs/xfs/linux-2.6/xfs_file.c +10 more+39 -1292 replies
5/17move v_iocount from bhv_vnode to xfs_inodefs/xfs/linux-2.6/xfs_aops.c fs/xfs/linux-2.6/xfs_aops.h fs/xfs/linux-2.6/xfs_vnode.c +5 more+44 -342 replies
6/17move v_trace from bhv_vnode to xfs_inodefs/xfs/linux-2.6/xfs_aops.c fs/xfs/linux-2.6/xfs_ioctl.c fs/xfs/linux-2.6/xfs_super.c +11 more+115 -1152 replies
7/17kill the v_number member in struct bhv_vnodefs/xfs/linux-2.6/xfs_vnode.c fs/xfs/linux-2.6/xfs_vnode.h fs/xfs/xfs_iget.c +1 more+2 -140 replies
8/17kill struct bhv_vnodefs/xfs/dmapi/xfs_dm.c fs/xfs/dmapi/xfs_dm_bhv.c fs/xfs/linux-2.6/xfs_iops.c +11 more+65 -752 replies
9/17move freeing the mount structure from xfs_mount_free into the callersfs/xfs/linux-2.6/xfs_vfs.c fs/xfs/xfs_mount.c fs/xfs/xfs_vfsops.c+2 -10 replies
11/17remove dependency of the quota module on behaviors.fs/xfs/linux-2.6/xfs_ksyms.c fs/xfs/linux-2.6/xfs_super.c fs/xfs/linux-2.6/xfs_super.h +10 more+220 -3073 replies
12/17decontaminate vfs operations from behavior detailsfs/xfs/Makefile-linux-2.6 fs/xfs/linux-2.6/xfs_super.c fs/xfs/linux-2.6/xfs_super.h +5 more+208 -720 replies
13/17call common xfs vnode-level helpers directly and remove vnode operationsfs/xfs/Makefile-linux-2.6 fs/xfs/dmapi/xfs_dm_fsops.c fs/xfs/linux-2.6/xfs_export.c +18 more+60 -11730 replies
14/17kill the vfs_fsid and vfs_altfsid members in struct bhv_vfs.fs/xfs/dmapi/xfs_dm.c fs/xfs/dmapi/xfs_dm_fsops.c fs/xfs/linux-2.6/xfs_ioctl.c +4 more+17 -470 replies
15/17kill the vfs_flags member in struct bhv_vfsfs/xfs/dmapi/xfs_dm.c fs/xfs/linux-2.6/xfs_export.c fs/xfs/linux-2.6/xfs_file.c +15 more+61 -841 reply
16/17move syncing related members from struct bhv_vfs to struct xfs_mountfs/xfs/linux-2.6/xfs_super.c fs/xfs/linux-2.6/xfs_vfs.c fs/xfs/linux-2.6/xfs_vfs.h +1 more+65 -750 replies
17/17kill struct bhv_vfsfs/xfs/Makefile-linux-2.6 fs/xfs/dmapi/xfs_dm.c fs/xfs/linux-2.6/xfs_ksyms.c +14 more+46 -1900 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/17] vnode/vfs and vnode/vfs operations removal

XFS has long carried around some baggage left from IRIX, and the vnodes and vfs objects aswell as the associated operation vectors re probably the worst, both in their impact in size aswell as in maintainability of the code. This patchset removes all this cruft, and allow at the same time to do a more clear split between the generic and the linux-specific parts of the current XFS codebase.

The patchseries allows for some quite nice reduction in size of both the source an binary code:

 113 files changed, 2114 insertions(+), 4002 deletions(-)

-rw-r--r-- 1 hch hch 9394858 2007-08-23 19:43 xfs.ko.new -rw-r--r-- 1 hch hch 9660812 2007-08-23 19:13 xfs.ko.old