Skip to content

omap2 clock: resend: framework generalization, cleanup

Paul Walmsley linux-omap 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest27 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/27omap2 clock: dsp_ick parent is dsp_fck, not core_ckarch/arm/mach-omap2/clock.h+1 -10 replies
2/27omap2 clock: generalize initial clock rate setup: recalculate_root_clocks()arch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h arch/arm/plat-omap/clock.c +1 more+23 -50 replies
3/27omap2 clock: mark onchip_clksas __initdataarch/arm/mach-omap2/clock.h+1 -10 replies
4/27omap2 clock: remove superfluous omap2_propagate_rate()arch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+8 -170 replies
5/27omap2 clock: rename, add comment to omap2_mpu_recalc()arch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+9 -40 replies
6/27omap2 clock: add clksel and clksel_rate dataarch/arm/mach-omap2/board-n800-audio.c arch/arm/mach-omap2/clock.h include/asm-arm/arch-omap/clock.h+557 -170 replies
7/27omap2 clock: init clksel clock parents to hardware reality at clock initarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+76 -50 replies
8/27omap2 clock: convert omap2_clksel_to_divisor and omap2_divisor_to_clksel to use new clksel structarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+102 -330 replies
9/27omap2 clock: convert omap2_clksel_round_rate to use new clksel structarch/arm/mach-omap2/clock.c+50 -480 replies
10/27omap2 clock: convert omap2_get_clksel to use new clksel structarch/arm/mach-omap2/clock.c+13 -790 replies
11/27omap2 clock: convert omap2_clksel_get_src_field() to use new clksel structarch/arm/mach-omap2/clock.c+25 -1810 replies
12/27omap2 clock: stop using clk->src_offset in omap2_clk_set_rate()arch/arm/mach-omap2/clock.c+3 -60 replies
13/27omap2 clock: stop using clk->src_offset in omap2_clk_set_parent()arch/arm/mach-omap2/clock.c+4 -10 replies
14/27omap2 clock: clean out old code from omap2_clksel_recalc()arch/arm/mach-omap2/clock.c+8 -160 replies
15/27omap2 clock: convert remaining clksel clocks to use omap2_clksel_recalcarch/arm/mach-omap2/clock.h+27 -290 replies
16/27omap2 clock: remove all {src, rate}_offset fields from struct clkarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h include/asm-arm/arch-omap/clock.h+6 -410 replies
17/27omap2 clock: use the struct clk round_rate field for clksel rate rounding codearch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+51 -120 replies
18/27omap2 clock: separate clksel set_rate code into its own functionarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+87 -530 replies
19/27omap2 clock: drop RATE_CKCTL from all OMAP2 clocksarch/arm/mach-omap2/clock.h+21 -240 replies
20/27omap2 clock: remove *_SEL* clock flagsarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h include/asm-arm/arch-omap/clock.h+41 -850 replies
21/27omap2 clock: call clock-specific enable/disable functions if presentarch/arm/mach-omap2/clock.c+8 -00 replies
22/27omap2 clock: use custom osc_ck enable/disable routinesarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+19 -180 replies
23/27omap2 clock: use standard clk->enable/disable for APLLsarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+14 -120 replies
24/27omap2 clock: replace omap2_get_crystal_rate() with clock-specific recalc codearch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h+29 -250 replies
25/27omap2 clock: Standardize DPLL rate recalculation with struct dpll_dataarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h include/asm-arm/arch-omap/clock.h+60 -180 replies
26/27omap2 clock: generalize clock enable upon framework initializationarch/arm/mach-omap2/clock.c arch/arm/mach-omap2/clock.h arch/arm/plat-omap/clock.c +1 more+20 -160 replies
27/27omap2 clock: add three missing clocks: gpmc_fck, sdma_{i, f}ckarch/arm/mach-omap2/clock.h+24 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/27] omap2 clock: resend: framework generalization, cleanup

Hello,

this patch set is the same set that I sent before, but some style issues have been cleaned up, and the last autoidle patch dropped for now. I've updated the diffstat and size output, and refreshed the patches against current git HEAD, 3c5639c. Should be ready to apply.

- Paul

-----

Hello,

This set of patches contains some significant changes to the OMAP2 clock framework. The main goal of these patches is to generalize the framework enough to be usable for the OMAP3430 clock tree, although in the process I think the OMAP2 clock code is improved quite a bit - I hope you'll agree.

The major change in this patch set is the rewrite of clksel clock handling, which:

* enables clksel parent clocks to be updated at clock framework init, from whatever the bootloader configured,

* properly encodes platform restrictions for particular rates,

* generalizes the clksel code to be useful for OMAP3430 clocks,

* facilitates future improved clock state reporting,

* and improves readability and maintainability.

The clksel patches are patches 6 through 20. A few other notable changes in this patchset:

* Cleanups/bug fixes: patches 1, 3, 4, 5

* Generalize root clock propagation at clock framework init: patch 2

* Use OMAP clock framework enable/disable fns for osc_ck, APLLs: patches 21, 22, 23

* Recalculate osc_ck and sys_ck via recalculate fns, rather than omap2_get_crystal_rate(): patch 24

* Generalize DPLL multiplier, divider handling: patches 25

* Generalize clocks enabled at init via ENABLE_ON_INIT clock flag: patch 26

* Generalize clock autoidle configuration: patches 27

The patches were boot-tested on N800. Comments and testing are appreciated. In particular, any testing on 2430SDP is particularly welcome, since I don't have one here.

Patches apply cleanly against current git head 3c5639c, and seem to run fine, but I've been doing most of my testing against 2.6.22-omap1, since my N800 touchscreen does not work consistently with recent 2.6.23 revs.

These changes increase uncompressed kernel memory footprint by about 5kB:
text data bss dec hex filename

2848436  147732   85992 3082160  2f07b0 vmlinux.orig
2851388  149740   85992 3087120  2f1b10 vmlinux

diffstat:

 arch/arm/mach-omap2/clock.c                       |  880 ++++++++------------
 arch/arm/mach-omap2/clock.h                       |  957 ++++++++++++++++------
 arch/arm/plat-omap/clock.c                        |   11
 include/asm-arm/arch-omap/clock.h                 |   21
 linux-omap/arch/arm/mach-omap2/board-n800-audio.c |   13
 linux-omap/arch/arm/mach-omap2/clock.c            |    8
 linux-omap/arch/arm/mach-omap2/clock.h            |   24
 linux-omap/arch/arm/plat-omap/clock.c             |   17
 linux-omap/include/asm-arm/arch-omap/clock.h      |   25
 9 files changed, 1227 insertions(+), 729 deletions(-)

My apologies in advance for the double 'Index:' lines in some of the patches - must be some quilt bug - it seems harmless and I have not yet had the chance to track it down.

- Paul