Skip to content

Sort module list for /proc/modules seq file reads

Mathieu Desnoyers lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2Seq_file add support for sorted listfs/seq_file.c include/linux/seq_file.h+67 -00 replies
2/2Sort module list by pointer address to get coherent sleepable seq_file iteratorskernel/module.c+21 -50 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/2] Sort module list for /proc/modules seq file reads

Hi Andrew,

Here is the updated version of the module list sort for coherent seq file reads. It includes, in the comments, a byte-by-byte test case that shows the race it solves. It has been updated since the last post to make sure the byte-by-byte read works correctly by using "pos" instead of m->private as position indicator.

Only /proc/modules is provided as a user, but it should eventually be used by other kernel parts, such as kallsyms, to make sure they protect themselves from list modification while they iterate on them.

It applies to 2.6.23-rc3-mm1.

Mathieu

Signature · 3 lines
Mathieu Desnoyers
Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F  BA06 3F25 A8FE 3BAE 9A68

Read the cover letter in its thread