Skip to content

scsi_data_buffer structure (in preparation for bidi)

FUJITA Tomonori linux-scsi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9add scsi_data_buffer structuredrivers/scsi/scsi_lib.c include/scsi/scsi_cmnd.h+69 -540 replies
2/9convert sd and sr to use scsi_data_bufferdrivers/scsi/sd.c drivers/scsi/sr.c+16 -150 replies
3/9convert scsi_error.c to use scsi_data_bufferdrivers/scsi/scsi_error.c+11 -180 replies
4/9scsi_debug: convert to use the data buffer accessorsdrivers/scsi/scsi_debug.c+10 -262 replies
5/9tgt: convert to use scsi_data_bufferdrivers/scsi/scsi_tgt_if.c drivers/scsi/scsi_tgt_lib.c+15 -140 replies
6/9tgt: convert ibmvstgt and libsrp to use scsi_data_bufferdrivers/scsi/ibmvscsi/ibmvstgt.c drivers/scsi/libsrp.c+15 -146 replies
7/9qla1280: convert to use the data buffer accessorsdrivers/scsi/qla1280.c+154 -2150 replies
8/9ide-scsi: convert to use the data buffer accessorsdrivers/scsi/ide-scsi.c+12 -110 replies
9/9libata-scsi: convert to use the data buffer accessorsdrivers/ata/libata-scsi.c+13 -260 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] scsi_data_buffer structure (in preparation for bidi)

This patchset, which I submitted before, adds a new data structure, scsi_data_buffer, including everything for data transfer:

struct scsi_data_buffer {
	unsigned length;
	int resid;
	short sg_count;
	short __sg_count;
	struct scatterlist *sglist;
};

One scsi_data_buffer structure is embedded in struct scsi_cmnd for uni-directional transfer. All the members are just moved from scsi_cmnd structure to scsi_data_buffer structure. So nothing is added to scsi_cmnd structure.

After applying this patchset, llds must use the scsi data accessors. This patchset includes some conversation patches (most of them are patches that Boaz submitted before), however there is still some code that is needed to be converted.

Boaz, if you still have other conversation patches, please submit them.

I suspect that nobody cares about some of unconverted llds, which will be not compilable after this patchset. I'll fix ldds that people complain about.

It's difficult to test this patchset in -mm via scsi-misc. Jens, please send this to -mm via the block tree.