Skip to content

Cleanup add-vmcoreinfo.patch

Ken'ichi Ohmichi kexec lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3Cleanup the coding style according to Andrew's commentsinclude/linux/kexec.h kernel/kexec.c kernel/ksysfs.c+15 -130 replies
2/3Add nodemask_t's size and NR_FREE_PAGES's value to vmcoreinfo_datainclude/linux/kexec.h kernel/kexec.c+7 -00 replies
3/3Use the existing ia64_tpa() instead of asm codearch/ia64/kernel/machine_kexec.c+2 -40 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] [-mm patch] Cleanup add-vmcoreinfo.patch

Hi Andrew,

Quoted 4 lines · Andrew Morton

Changes since 2.6.23-rc3-mm1:
[snip]
+add-vmcoreinfo.patch

Thank you for merging add-vmcoreinfo.patch.
I created the patchset for your comments and some corrections. The patchset is for linux-2.6.23-rc4-mm1.

[1/3] Cleanup the coding style according to Andrew's comments:
http://lists.infradead.org/pipermail/kexec/2007-August/000522.html
- vmcoreinfo_append_str() should have suitable __attribute__s so that the compiler can check its use.
- vmcoreinfo_max_size should have size_t.
- Use get_seconds() instead of xtime.tv_sec.
- Use init_uts_ns.name.release instead of UTS_RELEASE.

[2/3] Add nodemask_t's size and NR_FREE_PAGES's value to vmcoreinfo_data.
The dump filetering command 'makedumpfile'(v1.1.6 or before) had assumed the above values, and it was not good from the reliability viewpoint. So makedumpfile v1.2.0 came to need these values and I created the patch to let the kernel output them.
makedumpfile site:
https://sourceforge.net/projects/makedumpfile/

[3/3] Use the existing ia64_tpa() instead of asm code.

Thanks
Ken'ichi Ohmichi

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec