Skip to content

x86 2.6.24 patches review II

Andi Kleen lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest50 patches 54 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/50x86_64: store core id bits in cpuinfo_x8arch/x86_64/kernel/setup.c include/asm-x86_64/processor.h+49 -240 replies
2/50x86_64: use core id bits for apicid_to_node initializationarch/x86_64/mm/k8topology.c+10 -70 replies
3/50x86_64: remove never used apic_mappedarch/x86_64/kernel/apic.c include/asm-x86_64/apic.h+2 -40 replies
4/50x86: add cpu codenames for Kconfig.cpuarch/i386/Kconfig.cpu arch/x86_64/Kconfig+34 -69 replies
5/50i386: change order in Kconfig.cpuarch/i386/Kconfig.cpu+6 -70 replies
6/50i386: clean up oops/bug reportsarch/i386/kernel/traps.c arch/i386/mm/fault.c+11 -183 replies
7/50x86: expand /proc/interrupts to include missing vectors, v2Documentation/filesystems/proc.txt arch/i386/kernel/apic.c arch/i386/kernel/cpu/mcheck/p4.c +11 more+115 -52 replies
8/50x86_64: remove x86_cpu_to_log_apicidarch/x86_64/kernel/genapic.c arch/x86_64/kernel/genapic_flat.c arch/x86_64/kernel/smpboot.c +1 more+0 -50 replies
9/50i386: validate against ACPI motherboard resourcesarch/i386/pci/init.c arch/i386/pci/mmconfig-shared.c arch/i386/pci/pci.h +2 more+144 -2211 replies
10/50x86_64: install unstripped copies of compat vdso on diskarch/x86_64/Makefile arch/x86_64/ia32/Makefile+27 -50 replies
11/50x86_64: Install unstripped copy of 64bit vdso to diskarch/x86_64/Makefile arch/x86_64/vdso/Makefile+17 -40 replies
12/50x86_64: Untable __init references between IO dataarch/x86_64/kernel/apic.c arch/x86_64/kernel/smpboot.c include/asm-x86_64/apic.h+31 -241 reply
13/50x86: Fix and reenable CLFLUSH support in change_page_attr()arch/i386/mm/pageattr.c arch/x86_64/mm/pageattr.c include/asm-i386/pgtable.h +1 more+115 -294 replies
14/50x86: Minor code-style cleanups to change_page_attrarch/i386/mm/pageattr.c arch/x86_64/mm/pageattr.c+2 -120 replies
15/50x86_64: Return EINVAL for unknown address in change_page_attrarch/x86_64/mm/pageattr.c+3 -11 reply
16/50x86: Use macros to modify the PG_arch_1 page flags in change_page_attrarch/i386/mm/pageattr.c arch/x86_64/mm/pageattr.c+15 -60 replies
17/50x86_64: remove STR() macrosarch/x86_64/ia32/ia32_binfmt.c include/asm-x86_64/hw_irq.h include/asm-x86_64/system.h+1 -100 replies
18/50x86_64: Save registers in saved_context during suspend and hibernationarch/x86_64/kernel/acpi/wakeup.S arch/x86_64/kernel/asm-offsets.c arch/x86_64/kernel/suspend.c +2 more+125 -1050 replies
19/50Experimental: detect if SVM is disabled by BIOSarch/x86_64/kernel/setup.c include/asm-i386/cpufeature.h include/asm-i386/msr-index.h+27 -27 replies
20/50x86_64: Fix some broken white space in arch/x86_64/mm/init.carch/x86_64/mm/init.c+20 -202 replies
21/50i386: Misc cpuinit annotationsarch/i386/kernel/msr.c+2 -20 replies
22/50i386: Misc cpuinit annotationsarch/i386/kernel/cpuid.c+4 -20 replies
23/50x86_64: Implement missing x86_64 function smp_call_function_mask()arch/x86_64/kernel/smp.c include/asm-x86_64/smp.h+65 -560 replies
24/50x86_64: Eliminate result signage problem in asm-x86_64/bitops.hinclude/asm-x86_64/bitops.h+1 -10 replies
25/50x86_64: Add parenthesis to IRQ vector macrosinclude/asm-x86_64/hw_irq.h+16 -160 replies
26/50i386: export i386 smp_call_function_mask() to modulesarch/i386/kernel/smp.c include/asm-i386/smp.h+10 -60 replies
27/50x86_64: Remove duplicated vsyscall nsec updatearch/x86_64/kernel/vsyscall.c+0 -10 replies
28/50i386: remove stub early_printk.carch/i386/kernel/Makefile arch/i386/kernel/early_printk.c+1 -20 replies
29/50x86: honor _PAGE_PSE bit on page walksarch/i386/mm/fault.c arch/x86_64/mm/fault.c+3 -20 replies
30/50x86_64: remove some dead codearch/x86_64/kernel/entry.S arch/x86_64/kernel/traps.c+0 -70 replies
31/50x86_64: honor notify_die() returning NOTIFY_STOParch/x86_64/kernel/mce.c arch/x86_64/kernel/traps.c arch/x86_64/mm/fault.c +1 more+27 -191 reply
32/50x86: Show last exception from/to register contentsDocumentation/kernel-parameters.txt arch/i386/kernel/cpu/amd.c arch/i386/kernel/cpu/common.c +8 more+125 -110 replies
33/50x86: rename .i assembler includes to .harch/i386/lib/semaphore.S arch/x86_64/lib/rwlock.S include/asm-i386/alternative-asm.h +9 more+74 -620 replies
34/50i386: Fix argument signedness warningsinclude/asm-i386/processor.h+6 -33 replies
35/50i386: Do cpuid_device_create() in CPU_UP_PREPARE instead of CPU_ONLINE.arch/i386/kernel/cpuid.c+19 -133 replies
36/50x86: Use raw locks during oopsesarch/i386/kernel/traps.c arch/x86_64/kernel/traps.c+15 -140 replies
37/50x86_64: Clean up mce= argument parsing slightlyDocumentation/kernel-parameters.txt arch/x86_64/kernel/mce.c+3 -30 replies
38/50x86_64: fix off-by-one in find_next_zero_stringarch/x86_64/lib/bitstr.c+1 -10 replies
39/50i386: fix 4 bit apicid assumption of mach-defaultinclude/asm-i386/mach-default/mach_apicdef.h+7 -10 replies
40/50i386: Fix section mismatcharch/i386/kernel/cpu/mcheck/therm_throt.c+1 -10 replies
41/50i386: fix section mismatch warning in intel.carch/i386/kernel/cpu/intel.c arch/i386/kernel/traps.c+15 -160 replies
42/50i386: constify wd_opsarch/i386/kernel/cpu/perfctr-watchdog.c+8 -60 replies
43/50x86: multi-byte single instruction NOPsarch/i386/kernel/alternative.c include/asm-i386/processor.h include/asm-x86_64/processor.h+66 -10 replies
44/50i386: Introduce "used_vectors" bitmap which can be used to reserve vectors.arch/i386/kernel/i8259.c arch/i386/kernel/io_apic.c arch/i386/kernel/traps.c +1 more+23 -60 replies
45/50x86_64: configure HPET_EMULATE_RTC automaticallyarch/x86_64/Kconfig+2 -10 replies
46/50x86: also show non-zero IRQ counts for vectors that currently don't have a handlerarch/i386/kernel/irq.c arch/x86_64/kernel/irq.c+28 -80 replies
47/50i386: avoid temporarily inconsistent pte-sarch/i386/mm/pgtable.c+1 -20 replies
48/50x86_64: return correct error code from child_rip in x86_64 entry.Sarch/x86_64/kernel/entry.S+1 -10 replies
49/50x86_64: Initialize 64bit registers for a.out executablesarch/x86_64/ia32/ia32_aout.c+2 -00 replies
50/50x86_64: Remove fpu io port resourcearch/x86_64/kernel/setup.c+0 -27 replies

Reviews trailers per patch

5 of 50 patches have a Reviewed-by or Acked-by.

PatchSam RavnborgLinus TorvaldsChuck EbbertJoe Korty
1/50
2/50
3/50
4/50A-b
5/50A-b
6/50R-b
7/50A-b
8/50
9/50A-b
10/50
11/50
12/50
13/50
14/50
15/50
16/50
17/50
18/50
19/50
20/50
21/50
22/50
23/50
24/50
25/50
26/50
27/50
28/50
29/50
30/50
31/50
32/50
33/50
34/50
35/50
36/50
37/50
38/50
39/50
40/50
41/50
42/50
43/50
44/50
45/50
46/50
47/50
48/50
49/50
50/50

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 4 reviewers.

Read the v1 thread

Cover letter [PATCH] [0/50] x86 2.6.24 patches review II

- More cleanups and bug fixes
- Use CLFLUSH in c_p_a(). This were the patches that caused some trouble in -mm with X11, but it should be hopefully fixed now (we'll see)
- Report all IPIs in /proc/interrupts (useful e.g. to find out why CPU isolation fails)
- Experimental patch to disable SVM for the clinical paranoid
- Dump the LER registers on Oopses by default (note that this is not 100% reliable -- we know how to make it reliable, but that's not implemented yet)

Please review.

-Andi