Skip to content

PowerPC: ibmebus refactoring and fixes

Joachim Fenkes linuxppc-dev lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PowerPC: Move of_device allocation into of_device.[ch]arch/powerpc/kernel/of_device.c arch/powerpc/kernel/of_platform.c include/asm-powerpc/of_device.h +1 more+91 -682 replies
2/5ibmebus: Remove bus match/probe/remove functionsarch/powerpc/kernel/ibmebus.c+6 -1932 replies
3/5ibmebus: Add device creation and bus probing based on of_devicearch/powerpc/kernel/ibmebus.c+81 -162 replies
4/5ibmebus: Move to of_device and of_platform_driver, match eHCA and eHEA driversarch/powerpc/kernel/ibmebus.c drivers/infiniband/hw/ehca/ehca_classes.h drivers/infiniband/hw/ehca/ehca_eq.c +4 more+79 -1012 replies
5/5ibmebus: More speaking error return code in ibmebus_store_probe()arch/powerpc/kernel/ibmebus.c+2 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] PowerPC: ibmebus refactoring and fixes

This patchset will merge the ibmebus and of_platform bus drivers by basing a lot of ibmebus functionality on of_platform code and adding the features specific to ibmebus on top of that.

I split the actual ibmebus rework into three patches (2/5-4/5) for easier readability. The kernel will compile during the intermediate states, and ibmebus will not crash, but not work either.

As a side-effect of patch 3/5, a problem with bus_id collisions in case of two devices sharing the same location code is resolved -- the bus_id is now determined differently.

[1/5] moves of_device allocation into of_device.[ch] [2/5] removes the old bus match/probe/remove functions [3/5] adds device creation and bus probing based on of_device [4/5] finally moves to of_device and of_platform_driver by changing
ibmebus.h and matching the eHCA and eHEA drivers
[5/5] just changes a nit in ibmebus_store_probe()

These patches should apply cleanly, in order, against 2.6.23-rc5 and against Linus' git. Please review and comment them, and queue them up for 2.6.24 if you think they're okay.

Thanks and regards,
Joachim

arch/powerpc/kernel/ibmebus.c | 263 ++++++++-----------------=
=2D---

 arch/powerpc/kernel/of_device.c           |   80 +++++++++
 arch/powerpc/kernel/of_platform.c         |   70 +--------
 drivers/infiniband/hw/ehca/ehca_classes.h |    2 +-
 drivers/infiniband/hw/ehca/ehca_eq.c      |    6 +-
 drivers/infiniband/hw/ehca/ehca_main.c    |   32 ++--
 drivers/net/ehea/ehea.h                   |    2 +-
 drivers/net/ehea/ehea_main.c              |   72 ++++----
 include/asm-powerpc/ibmebus.h             |   38 +----
 include/asm-powerpc/of_device.h           |    4 +
 include/linux/of_device.h                 |    5 +
 11 files changed, 226 insertions(+), 348 deletions(-)

=2D-=20
Joachim Fenkes =A0-- =A0eHCA Linux Driver Developer and Hardware Tamer IBM Deutschland Entwicklung GmbH =A0-- =A0Dept. 3627 (I/O Firmware Dev. 2) Schoenaicher Strasse 220 =A0-- =A071032 Boeblingen =A0-- =A0Germany
eMail: [email protected]