Skip to content

: Use generic netlink functions for nfnetlink

Patrick McHardy netfilter-devel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/9: nfnetlink: make subsystem and callbacks constinclude/linux/netfilter/nfnetlink.h net/netfilter/nf_conntrack_netlink.c net/netfilter/nfnetlink.c +2 more+22 -220 replies
2/9: nfnetlink: convert to generic netlink attribute functionsinclude/linux/netfilter/Kbuild include/linux/netfilter/nfnetlink.h include/linux/netfilter/nfnetlink_compat.h +14 more+527 -5320 replies
3/9: nfnetlink: rename functions containing 'nfattr'include/linux/netfilter/nfnetlink.h include/net/netfilter/nf_conntrack_helper.h include/net/netfilter/nf_conntrack_l3proto.h +19 more+101 -1010 replies
4/9: nfnetlink: use nlmsg_notify()net/netfilter/nfnetlink.c+1 -100 replies
5/9: nfnetlink: support attribute policiesinclude/linux/netfilter/nfnetlink.h net/netfilter/nfnetlink.c+14 -360 replies
6/9: nfnetlink_log: use netlink policynet/netfilter/nfnetlink_log.c+9 -290 replies
7/9: nfnetlink_queue: use netlink policynet/netfilter/nfnetlink_queue.c+11 -190 replies
8/9: ctnetlink: use netlink policyinclude/net/netfilter/nf_conntrack_l3proto.h include/net/netfilter/nf_conntrack_l4proto.h net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c +9 more+97 -1000 replies
9/9: nfnetlink: kill nlattr_bad_sizeinclude/linux/netfilter/nfnetlink.h+0 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [NETFILTER 00/09]: Use generic netlink functions for nfnetlink

I've queued these patches which convert nfnetlink to use the generic netlink functions. Will push upstream after a bit more testing. Comments, review and patches on top to use the typeful attribute parsing/dumping functions (NLA_PUT_BE32, nla_get_u32, ...) welcome :)

 include/linux/netfilter/Kbuild                 |    1 +
 include/linux/netfilter/nfnetlink.h            |   98 +-----
 include/linux/netfilter/nfnetlink_compat.h     |   61 +++
 include/net/netfilter/nf_conntrack_helper.h    |    2 +-
 include/net/netfilter/nf_conntrack_l3proto.h   |    9 +-
 include/net/netfilter/nf_conntrack_l4proto.h   |   17 +-
 include/net/netfilter/nf_nat_protocol.h        |    8 +-
 net/ipv4/netfilter/nf_conntrack_l3proto_ipv4.c |   30 +-
 net/ipv4/netfilter/nf_conntrack_proto_icmp.c   |   40 +-
 net/ipv4/netfilter/nf_nat_core.c               |   22 +-
 net/ipv4/netfilter/nf_nat_proto_gre.c          |    4 +-
 net/ipv4/netfilter/nf_nat_proto_icmp.c         |    4 +-
 net/ipv4/netfilter/nf_nat_proto_tcp.c          |    4 +-
 net/ipv4/netfilter/nf_nat_proto_udp.c          |    4 +-
 net/ipv6/netfilter/nf_conntrack_l3proto_ipv6.c |   30 +-
 net/ipv6/netfilter/nf_conntrack_proto_icmpv6.c |   40 +-
 net/netfilter/nf_conntrack_core.c              |   31 +-
 net/netfilter/nf_conntrack_netlink.c           |  498 ++++++++++++-----------
 net/netfilter/nf_conntrack_proto_gre.c         |    5 +-
 net/netfilter/nf_conntrack_proto_tcp.c         |   87 +++--
 net/netfilter/nf_conntrack_proto_udp.c         |   10 +-
 net/netfilter/nf_conntrack_proto_udplite.c     |   10 +-
 net/netfilter/nfnetlink.c                      |  107 ++----
 net/netfilter/nfnetlink_log.c                  |  155 ++++-----
 net/netfilter/nfnetlink_queue.c                |  133 +++----
 25 files changed, 665 insertions(+), 745 deletions(-)
 create mode 100644 include/linux/netfilter/nfnetlink_compat.h

Patrick McHardy (9):
[NETFILTER]: nfnetlink: make subsystem and callbacks const [NETFILTER]: nfnetlink: convert to generic netlink attribute functions [NETFILTER]: nfnetlink: rename functions containing 'nfattr' [NETFILTER]: nfnetlink: use nlmsg_notify()
[NETFILTER]: nfnetlink: support attribute policies [NETFILTER]: nfnetlink_log: use netlink policy [NETFILTER]: nfnetlink_queue: use netlink policy [NETFILTER]: ctnetlink: use netlink policy
[NETFILTER]: nfnetlink: kill nlattr_bad_size