Skip to content

various lockdep patches

Peter Zijlstra linux-arch lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/12lockdep: syscall exit checkinclude/linux/lockdep.h kernel/lockdep.c+18 -03 replies
2/12lockdep: i386: connect the sysexit hookarch/i386/kernel/entry.S include/asm-i386/irqflags.h+16 -00 replies
3/12lockdep: x86_64: connect the sysexit hookarch/x86_64/kernel/entry.S arch/x86_64/lib/thunk.S include/asm-x86_64/irqflags.h+16 -00 replies
4/12lockdep: annotate journal_start()fs/jbd/transaction.c include/linux/jbd.h+14 -00 replies
5/12mm: trylock_pagefs/afs/write.c fs/cifs/file.c fs/jbd/commit.c +14 more+27 -223 replies
6/12mm: remove raw SetPageLocked() usagemm/filemap.c mm/swap_state.c+2 -21 reply
7/12lockdep: page lock hooksinclude/linux/pagemap.h mm/filemap.c+38 -150 replies
8/12lockdep: increase MAX_LOCK_DEPTHinclude/linux/sched.h+1 -10 replies
9/12lockdep: add a page lock class per filesystem typefs/filesystems.c include/linux/fs.h+6 -00 replies
10/12lockdep: lock_page: handle IO-completionsfs/buffer.c fs/mpage.c fs/nfs/read.c +2 more+28 -70 replies
11/12mm: set_page_mapping()include/linux/pagemap.h mm/filemap.c mm/migrate.c+14 -50 replies
12/12lockdep: enable lock_page lockdep annotationinclude/linux/lockdep.h include/linux/pagemap.h mm/filemap.c+52 -00 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchMartin Schwidefsky
SeriesR-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/12] various lockdep patches

The first 3 patches provide a new lockdep check, it verifies we don't hold any locks when returning to userspace.

	lockdep-sys_exit.patch
	lockdep-i386-sys_exit.patch
	lockdep-x86_64-sys_exit.patch

Could the various arch maintainers that have support for lockdep help out with placing this hook?

A journal_start annotation:

jbd-lock.patch

Up until this point stuff should be safe to merge (assuming there are no objections and bugs.. :-)

The rest of the series annotates lock_page():

rework lock_page() API:
trylock_page.patch
lock_page.patch
lockdep-page_lock-hooks.patch

actuall lockdep annotation:
lockdep-depth.patch
lockdep-fs-page.patch
lockdep-page-async.patch
set_page_mapping.patch
lockdep-lock_page.patch

Part of that is re-working the lock_page() API a bit. It introduces trylock_page(), and removes all the raw *PageLock() usage.

I've compile and boot tested this series on x86_64 (with and without lockdep). And it completes an LTP run with lockdep enabled.

Andrew, can we start by pusing the lock_page() API rework into -mm?

[ this series is against -linus, but if you're willing I'll do some
patches against -mm ]