: Encoding, inserting, and processing Feature-Negotiation options
Get series with b4
b4 am 200710011518.08134@strip-the-willowVersions newest first
- v1 Latest11 patches 16 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/11 | : Auxiliary function for smallest-fit option lengthsinclude/ net/ net/ | +15 | 3 replies | |
| 2/11 | : Increase the scope of variable-length htonl/ntohl functionsnet/ net/ | +16 | 1 reply | |
| 3/11 | : Upgrade NDP count from u32 to u64include/ net/ net/ +2 more | +22 | 1 reply | |
| 4/11 | : Support for Mandatory optionsnet/ net/ | +17 | 1 reply | |
| 5/11 | : Update insertion routine for feature-negotiation optionsnet/ net/ net/ +1 more | +39 | 2 replies | |
| 6/11 | : Insert feature-negotiation options into skbnet/ net/ net/ | +59 | 3 replies | |
| 7/11 | : Integrate feature-negotiation insertion codenet/ | +19 | 1 reply | |
| 8/11 | : Preference list reconciliationnet/ | +50 | 1 reply | |
| 9/11 | : Fill in the Data1..3 fields when option processing encounters option errorsnet/ | +12 | 1 reply | |
| 10/11 | : Process incoming Change requestsnet/ net/ net/ | +132 | 1 reply | |
| 11/11 | : Processing Confirm optionsnet/ net/ net/ | +99 | 1 reply |
Reviews trailers per patch
All 11 patches have a Reviewed-by or Acked-by.
| Patch | Ian McDonald |
|---|---|
| 1/11 | A-b |
| 2/11 | A-b |
| 3/11 | A-b |
| 4/11 | A-b |
| 5/11 | A-b |
| 6/11 | A-b A-b |
| 7/11 | A-b |
| 8/11 | A-b |
| 9/11 | A-b |
| 10/11 | A-b |
| 11/11 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/11]: Encoding, inserting, and processing Feature-Negotiation options
Patch #1: Increases the find-smallest-optlen function to go up to 6 bytes
which is the maximum for Seq Window and NDP count; and adds a Fixme, since some of the code still refers to an older draft using 3-bytes NDP count (wireshark was the same).
Patch #2: In the same manner, the scope of the variable-length htonl/ntohl
functions dccp_{de,en}code_value_var() is increased to up to 6 bytes.
Patch #3: Resolves the problem raised in patch#1 and updates NDP count usage from
3 to 6 bytes. The CCID3 code got an overflow warning instead of a full
update: let's first wait and celebrate the first connection to hit an NDP count of 2^32-1. Until that happens, many other problems can be resolved.
Patch #4: An dccp_insert_mandatory_opt() to add Mandatory option support (RFC 4340, 5.8.2)
Patch #5: Update for the dccp_insert_feat_opt() routine (more checks, more functionality).
Patch #6: The Feature-Negotiation end of the insert-into-skb business. This function now
calls the function in options.c. Unlike before, the interfaces between option-inserting code and feature-negotiation code are now separate, connected via this function.
Patch #7: Integrate insertion of feature-negotiation options at the server and the client (glue
patch for #5 and #6).
Patch #8: Routines for (a) reconciling SP preference lists, (b) reordering a preference list
so that a now-preferred entry comes first.
Patch #9: Support for filling in the Data 1..3 fields when option processing encounters an error.
Patch #10: Process incoming Change L/R requests. This is done in a combined routine now, since the
code takes two different paths:
- feature-negotiation during connection setup
- passing of NN options (such as Ack Ratio) in establihed socket state
Patch #11: Process incoming Confirm L/R responses. The internally-called function is still separate.