Skip to content

: Finish up the feature negotiation during connection setup

Gerrit Renker dccp 1 version In review

Get series with b4
b4 am 200710031502.25186@strip-the-willow

Versions newest first

  1. v1 Latest14 patches 21 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14: Activation of features after negotiationnet/dccp/dccp.h net/dccp/feat.c net/dccp/minisocks.c+212 -551 reply
2/14: Integration of dynamic feature activation - part 1 (socket setup)net/dccp/proto.c+4 -391 reply
3/14: Integration of dynamic feature activation - part 2 (server side)net/dccp/minisocks.c+12 -271 reply
4/14: Integration of dynamic feature activation - part 3 (client side)net/dccp/input.c+24 -41 reply
5/14: Clean up remains from old feature-negotiation infrastructurenet/dccp/feat.c net/dccp/feat.h net/dccp/proto.c+11 -972 replies
6/14: Remove now unused parts of the old CCID interfaceDocumentation/networking/dccp.txt include/linux/dccp.h net/dccp/ccid.c +3 more+7 -421 reply
7/14: No more CCID control blocks in LISTEN statenet/dccp/ccids/ccid3.c+4 -242 replies
7/14: No more CCID control blocks in LISTEN statenet/dccp/ccids/ccid3.c+7 -330 replies
8/14: Remove manual influence on NDP Count featureDocumentation/networking/dccp.txt net/dccp/dccp.h net/dccp/minisocks.c +1 more+0 -132 replies
9/14: Phase out the use of boolean flag for Ack Vectorsinclude/linux/dccp.h net/dccp/dccp.h net/dccp/diag.c +5 more+17 -302 replies
10/14: Initialisation framework for feature negotiationinclude/linux/dccp.h net/dccp/feat.c net/dccp/feat.h+61 -311 reply
11/14: Auto-load (when supported) CCID plugins for negotiationnet/dccp/ccid.c net/dccp/ccid.h net/dccp/feat.c+34 -101 reply
12/14: Implement both feature-local and feature-remote Sequence Window featureDocumentation/networking/dccp.txt include/linux/dccp.h net/dccp/dccp.h +2 more+30 -204 replies
13/14: Initialisation and type-checking of feature sysctlsinclude/linux/dccp.h net/dccp/dccp.h net/dccp/feat.c +2 more+54 -231 reply
14/14: Debugging Feature Negotiationnet/dccp/dccp.h net/dccp/feat.c net/dccp/feat.h +1 more+109 -611 reply

Reviews trailers per patch

14 of 15 patches have a Reviewed-by or Acked-by.

PatchIan McDonald
1/14A-b
2/14A-b
3/14A-b
4/14A-b
5/14A-b
6/14A-b
7/14A-b A-b
7/14A-b A-b
8/14A-b
9/14A-b
10/14A-b
11/14
12/14A-b
13/14A-b
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/14]: Finish up the feature negotiation during connection setup

This batch finishes the feature-negotiation during connection setup. The remaining batch considers exchanging FN options in established state, which is a different kettle of fish.

Patch #1: Introduces feature-activation handlers to dynamically
activate feature values after negotiation.

Patch #2: Integrates dynamic activation with socket initialisation (the full code
for pre-negotiation initialisation follows in patch #10).

Patch #3: Integrates dynamic activation with cild-socket creation.

Patch #4: Integrates dynamic activation at the client, before entering PARTOPEN.

Patch #5: Cleans up now unused bits of the infrastructure and updates copyrights.

Patch #6: Removes now unused bits of the CCID interface.

Patch #7: Removes test for LISTEN state in ccid3.c - CCIDs are now loaded only in
OPEN/PARTOPEN state.

Patch #8: Removes manual influence on NDP count feature - this is a CCID dependency.

Patch #9: Replaces the use of the boolean Ack Vector flag with an equivalent test
whether Ack Vectors are in use on the socket.

Patch #10: Initialisation framework for feature negotiation (pre-negotiation setup).

Patch #11: Auto-load CCIDs as part of the pre-negotiation setup. All advertised CCIDs
are pre-loaded, since feature negotiation is mostly in interrupt context. The modules are then ready to be used after the negotiation has converged.

Patch #12: Implement both sides of the Sequence Window feature (currently only one side
has been implemented).

Patch #13: Initialisation and type-checking of FN sysctl values.

Patch #14: Debugging and pretty-printing routines for feature negotiation.