: Bug fixes part 1
Get series with b4
b4 am 200710271234.17427@strip-the-willowVersions newest first
- v1 Latest6 patches 6 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | : Don't process Ack twice in Respond statenet/ | +1 | 1 reply | |
| 2/6 | : Bug in reading Ack Vectorsnet/ | +1 | 1 reply | |
| 3/6 | : Fix sequence number arithmetic/comparisonsnet/ | +2 | 1 reply | |
| 4/6 | : Don't assign negative values to Ack Rationet/ net/ | +6 | 1 reply | |
| 5/6 | : Deadlock and spurious timeouts when Ack Ratio > cwndnet/ | +21 | 1 reply | |
| 6/6 | : Larger initial windows also for CCID2net/ | +15 | 1 reply |
Reviews trailers per patch
5 of 6 patches have a Reviewed-by or Acked-by.
| Patch | Ian McDonald |
|---|---|
| 1/6 | A-b |
| 2/6 | |
| 3/6 | A-b |
| 4/6 | A-b |
| 5/6 | A-b |
| 6/6 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6]: Bug fixes part 1
A small batch of bug fixes, all for CCID2 apart from the first one. I have another small batch of CCID2 fixes and cleanups, which will be sent next week. All fixes are related to the problem that CCID2 can not currently deal well with Ack Ratios different from 1. To fully tackle this, Ack Vectors need a slight upgrade (see below).
Patch #1: Fixes a Feature-Negotiation problem where an Ack was parsed twice.
I submit this for the record, but would like to merge this patch (one-liner) with the one it is supposed to improve: this is the test-tree patch:
"[DCCP]: Integration of dynamic feature activation - part 3 (client side)"
Patch #2: Fixes a CCID2 bug in parsing Ack Vectors (triggers congestion event).
Patch #3: Fixes sequence number arithmetic in CCID2.
Patch #4: Avoids using negative values for Ack Ratio in assignment.
Patch #5: Tackles the problem of deadlock when cwnd < Ack Ratio.
Patch #6: Larger Initial Windows (RFC 3390) now also for CCID2.
Ack Vector update: The design and initial testing is largely finished, documentation
is on http://www.erg.abdn.ac.uk/users/gerrit/dccp/notes/ack_vectors/