Skip to content

pvSCSI (SCSI pass through) driver

Jun Kamada xen-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6pvSCSI (SCSI pass through) driverdrivers/xen/scsifront/Makefile drivers/xen/scsifront/comfront.c drivers/xen/scsifront/comfront.h +4 more+2205 -00 replies
2/6pvSCSI (SCSI pass through) driverdrivers/xen/scsiback/Makefile drivers/xen/scsiback/comback.c drivers/xen/scsiback/comback.h +6 more+2409 -00 replies
3/6pvSCSI (SCSI pass through) driverinclude/xen/interface/io/vscsiif.h+238 -00 replies
4/6pvSCSI (SCSI pass through) driverdrivers/xen/Kconfig drivers/xen/Makefile+33 -00 replies
5/6pvSCSI (SCSI pass through) driverunmodified_drivers/linux-2.6/Makefile unmodified_drivers/linux-2.6/scsifront/Kbuild unmodified_drivers/linux-2.6/scsifront/Makefile+10 -00 replies
6/6pvSCSI (SCSI pass through) drivertools/examples/Makefile tools/examples/scsihost tools/examples/xen-backend.agent +6 more+433 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] pvSCSI (SCSI pass through) driver

Keir-san,

I have finished the modification of the driver by option i.). The pvSCSI driver can work on heterogeneous (x86_32 and x86_64) environment.

I will attach total six patches on following mail.

Best regards,

Quoted 32 lines · On Thu, 25 Oct 2007 10:59:31 +0900 Jun Kamada <[email protected]> wrote:

Keir-san,

Quoted 11 lines · On Wed, 24 Oct 2007 08:42:38 +0100 Keir Fraser <[email protected]> wrote:
Quoted 9 lines · Jun Kamada
Quoted 3 lines

Anyway, the right answer is to ensure that your structures compile the same whether compiled with 32-bit or 64-bit gcc. Check the structure sizes, fields sizes and field offsets.

You showed me two options in previous email; i.) all the shared-memory structures defined in vscsiif.h compile identically for 32-bit and 64-bit mode, ii.) to detect the frontend's 'bitness' in scsiback and optionally do 32-to-64 or 64-to-32 conversion.

Quoted 7 lines
Quoted 3 lines

I consider that current VBD implementation takes option ii.), however you recommended me to take option i.) for pvSCSI driver. Is my understanding right?

Yes. It was an accident we ended up with structures compiling differently on 32- vs 64-bit. By the time we discovered it was an issue, we couldn't break backward compatibility.

I understood. I'll try to modify the pvSCSI driver by option i.).

Best regards,

-----
Jun Kamada

Quoted 4 lines

_______________________________________________
Xen-devel mailing list
[email protected]
http://lists.xensource.com/xen-devel

-----
Jun Kamada