: CCID2 fixes part 2/2
Get series with b4
b4 am 200711031323.30274@strip-the-willowVersions newest first
- v1 Latest9 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | : Disable broken Ack Ratio adaptation algorithmnet/ net/ | +21 | 1 reply | |
| 2/9 | : Remove unused variablenet/ net/ | +0 | 1 reply | |
| 3/9 | : Replace read-only variable with constantnet/ net/ | +5 | 1 reply | |
| 4/9 | : Replace cwnd assignment-function with assignmentnet/ net/ | +8 | 1 reply | |
| 5/9 | : Replace pipe assignment-function with assignmentnet/ net/ | +8 | 1 reply | |
| 6/9 | : Redundant debugging outputnet/ | +0 | 1 reply | |
| 7/9 | : Remove redundant synchronisation variablenet/ net/ | +2 | 1 reply | |
| 8/9 | : Remove redundant ack-counting variablenet/ net/ | +17 | 1 reply | |
| 9/9 | : Remove misleading commentnet/ | +1 | 1 reply |
Reviews trailers per patch
5 of 9 patches have a Reviewed-by or Acked-by.
| Patch | Ian McDonald |
|---|---|
| 1/9 | A-b |
| 2/9 | |
| 3/9 | |
| 4/9 | |
| 5/9 | |
| 6/9 | A-b |
| 7/9 | A-b |
| 8/9 | A-b |
| 9/9 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9]: CCID2 fixes part 2/2
This is the second part of various fixes / cleanups for CCID2. Quite a few variables and functions are removed, making it easier to follow what is going on in the code. This set has been tested for a while, further progress with CCID2 depends on the Ack Vector set (which is in the testing phase, but confident that it is coming close to being bug-free).
This set contains:
Patch #1: Disables a broken algorithm for decreasing Ack Ratio which
is based on ideas different from the ones in the RFC, is not related to the formula introduced there, and hence will decrease Ack Ratio unexpectedly and at the wrong times.
Patch #2: Dead code elimination (unused variable).
Patch #3: Read-only variable replaced by constant.
Patch #4: Inline/one-line function replaced by its body (cwnd).
Patch #5: Same as patch #4, but for pipe, obsoletes a BUG_ON.
Patch #6: Removes redundant debugging output (subsumed by other messages).
Patch #7: Removes redundant synchronisation variable.
Patch #8: Removes redundant ack-counting variable.
Patch #9: Misleading comment (false alarm); please see subsequent RFC message.